On Tue, 2016-01-19 at 16:08 -0800, Martin Michlmayr wrote:
> > sbuild (Debian sbuild) 0.67.0 (26 Dec 2015) on dl580gen9-02.hlinux
> ...
> > g++ -DHAVE_CONFIG_H -I. -DBINDIR='"/usr/bin"' -DSYSCONFDIR='"/etc"'
> > -DPKGDATADIR='"/usr/share/systemtap"' -DPKGLIBDIR='"/usr/lib/systemtap"'
> > -DLOCALEDIR='"/usr/share/locale"' -I./includes -I./includes/sys
> > -DSTAP_SDT_V2 -D_REENTRANT -I/usr/include/nss -I/usr/include/nspr
> > -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Werror -std=c++11 -D_REENTRANT
> > -I/usr/include/nss -I/usr/include/nspr -g -O2 -fstack-protector-strong
> > -Wformat -Werror=format-security -fstack-protector-all -D_FORTIFY_SOURCE=2
> > -c -o stap-stringtable.o `test -f 'stringtable.cxx' || echo
> > './'`stringtable.cxx
> > tapsets.cxx: In constructor
> > 'dwarf_derived_probe::dwarf_derived_probe(interned_string, interned_string,
> > int, interned_string, interned_string, Dwarf_Addr, Dwarf_Addr,
> > dwarf_query&, Dwarf_Die*)':
> > tapsets.cxx:5015:5: error: statement is indented as if it were guarded
> > by... [-Werror=misleading-indentation]
> > {
> > ^
> >
> > tapsets.cxx:5007:3: note: ...this 'if' clause, but it is not
> > if (has_maxactive && (maxactive_val < 0 || maxactive_val > USHRT_MAX))
> > ^~
> >
This particular issue comes from upstream commit:
commit a76968821332281d92f51a4873194cd8d13834d1
Author: Jonathan Lebon <jle...@redhat.com>
Date: Fri Mar 14 11:21:23 2014 -0400
PR16473: always expand $$vars/$$parms/etc...
Which removed a second if clause and said: "I kept the brackets on
rather than unindenting to keep the parent scope less polluted."
But personally I agree with the compiler that this is a little
confusing.
Cheers,
Mark
