* Manoj Srivastava <sriva...@acm.org> [2016-01-20 21:12]:

On Wed, Jan 20 2016, Rafael Laboissiere wrote:

Package: mailagent
Version: 1:3.1-81-1
Severity: important

       It might (and then again, it might not) be reassuring to know I
have exactly the same version of perl nd mailagent; and mailagent did pass all tests, including the compression tests. I have not seen the mail lossage (the defined(@array) is fairly benign, despite the dire warning) .

The attached patch fixed the problem for me. There may have other instances of defined(@array) in the code, but I did not check this carefully.

The problem with messages that are not dropped in ~/mbox.$user, in case of failure, is a separate bug from the one that is addressed by my patch.

Best,

Rafael
--- mailagent-3.1-81.orig/agent/pl/compress.pl
+++ mailagent-3.1-81/agent/pl/compress.pl
@@ -210,7 +210,7 @@
 sub restore {
 	return unless $cf'compress;		# Do nothing if no compress parameter
 	return unless -s $cf'compress;	# No compress list file, or empty
-	&init unless defined @compress;	# Initialize array only once
+	&init unless @compress;	# Initialize array only once
 	return unless defined $Ext{$cf'comptag};	# Invalid compression tag
 	local($folder) = @_;			# Folder candidate for uncompression
 	&'add_log("candidate folder is $folder") if $'loglvl > 18;

Reply via email to