Package: remmina
Version: 1.1.2-3
Severity: minor
Tags: patch

Hi,

the provided remmina.desktop is not completely valid (see also output
of `desktop-file-validate`).
The attached git-formatted commit fixes all the issues:
- the 'Keywords' key is a list, so it must end with the list separator
  (';')

Why is the patch marked as "Forwarded: not-needed"? This is something
that can indeed go upstream.

Thanks,
-- 
Pino
>From 5b81fbe40581a56078ae96b267e19a81832b35c2 Mon Sep 17 00:00:00 2001
From: Pino Toscano <p...@debian.org>
Date: Sun, 24 Jan 2016 11:32:54 +0100
Subject: [PATCH] make remmina.desktop valid

update patch 0005-desktop.patch by adding the list separator at the end
of the Keywords key
---
 debian/changelog                  | 7 +++++++
 debian/patches/0005-desktop.patch | 2 +-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 3dd71d5..8e0b68e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+remmina (1.1.2-3.1) UNRELEASED; urgency=medium
+
+  * Update patch 0005-desktop.patch by adding the list separator at the end of
+    the Keywords key: this makes remmina.desktop valid.
+
+ -- Pino Toscano <p...@debian.org>  Sun, 24 Jan 2016 11:31:26 +0100
+
 remmina (1.1.2-3) unstable; urgency=medium
 
   [ Jörg Frings-Fürst ]
diff --git a/debian/patches/0005-desktop.patch b/debian/patches/0005-desktop.patch
index 29b265f..977f69d 100644
--- a/debian/patches/0005-desktop.patch
+++ b/debian/patches/0005-desktop.patch
@@ -11,7 +11,7 @@ This patch header follows DEP-3: http://dep.debian.net/deps/dep3/Index: trunk/re
  Type=Application
  Categories=GTK;GNOME;X-GNOME-NetworkSettings;Network;
  Actions=Profile;Tray;
-+Keywords=remote desktop;rdp;vnc;nx,ssh
++Keywords=remote desktop;rdp;vnc;nx,ssh;
  
  [Desktop Action Profile]
  Name=Create a New Connection Profile
-- 
2.7.0.rc3

Reply via email to