Hi, Quoting Luca Falavigna (2016-02-01 16:34:11) > A dumb method could be checking whether the filesystem is listed in > /proc/filesystems: > $ cat /proc/filesystems | grep overlay > nodev overlay > $ > > But I think it will return nothing if overlay module is not loaded via > modprobe first, and again it's Linux-specific... > > A full check would be like this: > if system is Linux: > if /proc/filesystem contains overlayfs: > overlayfs available > else if modprobe overlay: > overlayfs available > else: > overlayfs not available > else: > overlayfs not available > > ... but my impression it's not 100% error-proof.
I don't think it needs to be. Should there be a system supporting overlayfs but without /proc/filesystem or where modprobe fails, then the user can still automatically edit their schroot configuration manually after having run sbuild-createchroot and then file a bug against sbuild about why the existing checks failed in their case at which point we can improve the check. You initially offered a patch - I'd definitely welcome one :) Thanks! cheers, josch
signature.asc
Description: signature
