Control: tags -1 + moreinfo

Hi,

[not the maintainer, just a happy user of the package]

On 2016-02-12 10:33, David Harding wrote:
In file /etc/init.d/openvpn on line 86 as part of the
start-stop-daemon call that starts the openvpn server, variable
$OPTARGS is used to pass arguments to the openvpn daemon.

$OPTARGS is not set anywhere in the script.

It's set in /etc/default/openvpn. However, it's used to pass *optional* arguments, so there's no requirement for it to be set at all.

I recommend that a line be inserted above this one to the following
effect:

OPTARGS="--config "$CONFIG_DIR/$NAME.conf

That doesn't make sense. The call to start the daemon is:

    start-stop-daemon --start --quiet --oknodo \
        --pidfile /run/openvpn/$NAME.pid \
        --exec $DAEMON -- $OPTARGS --writepid /run/openvpn/$NAME.pid \
        $DAEMONARG $STATUSARG --cd $CONFIG_DIR \
        --config $CONFIG_DIR/$NAME.conf || STATUS=1

so the --config argument that you propose will already be in use.

Regards,

Adam

Reply via email to