* Michael Banck <[EMAIL PROTECTED]> [2006-01-09 16:17]:
> > - unset base_dir now
> > - add a message like you suggested now
Hi Arne, we decided to unset base_dir by default on Debian (i.e., no
longer have it in /etc/jackrc by default, following your own's jackrc
file). I added a warning message to tell people where their files are
and that they can set base_dir. Below is a patch. I feel that adding
this new function will be helpful in the future to make some checks
regarding user configuration (e.g. checking for obsolete command line
options).
diff -urN jack-3.1.1~/jack jack-3.1.1/jack
--- jack-3.1.1~/jack 2006-01-11 13:31:39.000000000 +0000
+++ jack-3.1.1/jack 2006-01-11 13:48:44.000000000 +0000
@@ -84,6 +84,7 @@
debug("user_cf: " + `user_cf`)
debug("argv_cf: " + `argv_cf`)
+jack_checkopts.check_rc(global_cf, user_cf, argv_cf)
jack_checkopts.consistency_check(cf)
if cf['save_args']['val'] == 1:
diff -urN jack-3.1.1~/jack_checkopts.py jack-3.1.1/jack_checkopts.py
--- jack-3.1.1~/jack_checkopts.py 2006-01-11 13:31:39.000000000 +0000
+++ jack-3.1.1/jack_checkopts.py 2006-01-11 13:48:23.000000000 +0000
@@ -215,3 +215,13 @@
if cf['_dont_work'] and cf['_query_when_ready']:
warning("you want to use --query-now / -Q instead of --query / -q")
+
+# Checks concerning options specified by the user (in the global or user rc
+# files or the command line), i.e. options/values that are not the default
+# jack options from jack_config.
+def check_rc(global_cf, user_cf, argv_cf):
+
+ all_keys = global_cf.keys() + user_cf.keys() + argv_cf.keys()
+ if 'base_dir' not in all_keys:
+ warning("You have no standard location set, putting files into the
current directory. Please consider setting base_dir in ~/.jack3rc.")
+
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
