On 25.02.2016 04:51, Jelmer Vernooij wrote:
Thanks for the patch; I've committed it to git, will upload later. Two
small further comments:
On Fri, Feb 19, 2016 at 11:03:05AM +0100, Matthias Klose wrote:
updated patch, the .install files need the x bit set.
* Build python3 packages.
* Bump debhelper and standards version.
* Do not generate symbols for the extension module
Was there a specific reason you removed this? The extension module
should only export the init function anyway (so it'll never change),
Verifying that that is the only function exported doesn't seem bad
either, though it's also not super useful.
ok, I see what you want to achieve, however from my point of view a symbols file
is the wrong approach. If you want to ensure that just this symbol is visible,
ensure that by an objdump -T / nm check, but the symbols file tells users that
this is a public interface that they can rely on. There is just one user, the
python interpreter (whether embedded or standalone). Symbols files are only
shipped for shared libraries, never for any extension module.
* Do not encode the SOABI and the multiarch string into the pytalloc-util
library, just append a '-py3'.
* Make the build log a bit more verbose.
Making waf more verbose can be done by setting the "V" environment
variable; I've committed a change to simplify this.
ahh, working with an "uncommon" build system ...
Matthias
