Hi Peter, On Sat, 2016-03-19 at 14:43 +0000, peter green wrote: > On 19/03/16 12:26, peter green wrote: > > > > > > This seems to be a result of the recent pic related backports. I'm > > working on a fix now. > ok, the first thing I did was move globtype (which provides TSymStr) > from the implementation uses to the interface uses so it would be > available at that line. > > However I then discovered that the signature of the function in the new > patch did not match the signature of the function it was overriding. > > From the patch: > function a_call_name(list: TAsmList; pd: tprocdef; const s: TSymStr; > const paras: array of pcgpara; forceresdef: tdef; weak: boolean): > tcgpara; override; > > The overridden function. > function a_call_name(list : TAsmList;pd : tprocdef;const s : TSymStr; > forceresdef: tdef; weak: boolean): tcgpara;override; > > The only thing that was done with the parameter was to pass it through > to the inherited function so I simply got rid of it. > > The build then failed with > > /usr/bin/ppc386 -Ur -Xs -O2 -n -Fui386 -Fusystems > -Fu/fpc-3.0.0+dfsg/fpcsrc/rtl/units/i386-linux -Fii386 -FE. > -FUi386/units/i386-linux -dRELEASE > @/fpc-3.0.0+dfsg/debian/deb-host-fpc.cfg -di386 -dGDB -dBROWSERLOG > -Fux86 -Sew pp.pas > hlcgcpu.pas(187,21) Error: Identifier not found "po_external" > hlcgcpu.pas(192,21) Error: Identifier not found "taicpu" > hlcgcpu.pas(232) Fatal: There were 2 errors compiling module, stopping > > That was easy enough to fix, just adding a couple of things to the > implementation uses. > > The result of that was a successful build, I have not done any > functional tests of the result yet. Debdiff attached, if someone else > wants to test and commit/upload feel free to go ahead if not i'll do it > when I get around to it. > > I also notice some junk in the debdiff, presumablly the clean target > needs work. I've pushed your changes to git. Can you please pull and upload or should I upload? -- Cheers, Abou Al Montacir
signature.asc
Description: This is a digitally signed message part