On Thu, 2015-12-24 at 22:24 -0500, Christoph Goehre wrote:
> Hi Svante,
> 
> On Mi, Dez 16, 2015 at 10:33:07 +0100, Svante Signell wrote:
> > 
> > Currently icedove FTBFS on GNU/Hurd due to memory problems when linking
> > large
> > libraries. The attached patch fixes this problem by giving the --no-keep-
> > memory
> > flag to the linker as for alpha and ia64.
> I use 'ifneq' instead of 'ifeq', so everything EXCEPT alpha and ia64 build
> with
> 'LDFLAGS += -Wl,--no-keep-memory'. If I apply your patch, hurd wouldn't get
> -Wl,--no-keep-memory.

Noted!
But the rules:
ifneq ($(DEB_BUILD_ARCH),ia64)
        LDFLAGS += -Wl,--no-keep-memory -Wl,--reduce-memory-overheads
endif
ifneq ($(DEB_BUILD_ARCH),alpha)
        LDFLAGS += -Wl,--no-keep-memory
endif
would set LDFLAGS --no-keep-memory twice and --reduce-memory-overheads once for
all architectures not matching ia64,alpha, right?

> > 
> > Additionally, since dh_clean does not enable building a second time after a
> > build failure, add an override target for sh_auto_clean:
> > override_dh_auto_clean:
> >     make -f client.mk distclean
> Have you try to add this to debian/rules and build icedove from scratch?
> For me, it's not working, see:
> 

It does not work for me either. However the debian/rules is not OK, see below:

dpkg-buildpackage: host architecture hurd-i386
 fakeroot debian/rules clean
dh clean
   dh_testdir
   dh_auto_clean
   dh_clean
 debian/rules build
make: 'build' is up to date. <- This i not correct, the build hasn't even
started
 fakeroot debian/rules binary <- Never build a package under fakeroot, this is
not necessary and can can cause serious problems. I've seen this for other
packages too, it is probably a bug in the dh_* tools.
dh binary
   dh_testdir
   dh_update_autotools_config
   debian/rules override_dh_auto_configure
...

Additionally: debian/rules binary does not restart the build from scratch after
a failure. All built files e.g. under  obj-icedove and obj-<target_triple> are
still present, i.e. not cleaned out!

Reply via email to