Package: nm.debian.org
Severity: normal
Tags: patch
Dear Maintainer,
When claiming a new email through the web interface, I receive a
confirmation email with this header:
From: ('Debian New Member Frontdesk', '[email protected]')
which doesn't display well in email clients (they expect rfc822
format).
Attached is a patch to fix it!
Cheers,
--
Matthieu
-- System Information:
Debian Release: stretch/sid
APT prefers testing-updates
APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 4.3.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
>From d8b268491422180e06a8ea03c5a3e6745fec1d8f Mon Sep 17 00:00:00 2001
From: Matthieu Caneill <[email protected]>
Date: Sun, 3 Apr 2016 09:46:45 +0200
Subject: [PATCH] Fix email 'From:' format when emailing a claim message
Instead of having:
From: ('Debian New Member Frontdesk', '[email protected]')
we now get:
From: Debian New Member Frontdesk <[email protected]>
This is to respect rfc822.
---
contributor/views.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contributor/views.py b/contributor/views.py
index 1420632..a2a7de6 100644
--- a/contributor/views.py
+++ b/contributor/views.py
@@ -179,8 +179,10 @@ Thank you,
contributors.debian.org
""".format(user=email, claim=claim, url=url)
+ mail_from = '{0} <{1}>'.format(settings.ADMINS[0][0],
+ settings.ADMINS[0][1])
send_mail('Verify contributors.debian.org claim', message,
- settings.ADMINS[0], [claim], fail_silently=False)
+ mail_from, [claim], fail_silently=False)
messages.warning(request, 'Email sent to ' + claim +
'. Click on the verification link to complete the process')
return redirect("contributor_detail", name=email)
--
2.7.0
