Package: src:grib-api
Version: 1.14.7-2

Dear maintainer: I see a conditional dh_buildinfo line in debian/rules.

This is not good, and I explain why:

When we want a package being present during build, we use Build-Depends.

When we don't want a package being present during build, we use
Build-Conflicts.

There is an expectation that packages always build the same way
and a conditional line like that breaks such expectation. This is
also the reason why we don't have Build-Recommends.

Therefore, please don't call dh-buildinfo conditionally.

Patch attached.

Thanks.
--- a/debian/rules
+++ b/debian/rules
@@ -74,4 +74,3 @@ override_dh_fixperms-arch:
        dh_fixperms
        chmod +x 
debian/libgrib-api0/usr/share/grib_api/definitions/installDefinitions.sh
        chmod -x 
debian/libgrib-api-dev/usr/share/doc/libgrib-api-dev/examples/python/README
-       test -e /usr/bin/dh_buildinfo && dh_buildinfo

Reply via email to