Hi,
quite some time ago, Gianfranco wrote:
> something needs changes:
>
> - std-version is now 3.9.7
Done.
> - unsecure VCS fields
Done.
> - call ldconfig in rules? what?
Uh... removed.
> - changing names usually is just bad, people won't find the package,
> and you will diverge from upstream.
>
> do you have any good rationale?
The rationale is that there is already a libarb in Debian, which has
nothing to do with flint's ARB... so I'm trying to make sure there is no
name conflict.
> - do you pass --parallel twice? (I mean in build)
Uh... fixed.
> - what about dh_auto_configure -- (FLAGS) instead of ./configure?
> (I think the build fails for "unknown parameters, right?"
Bad idea: dh_auto_configure will think it's an autotools configure
script, which it isn't.
> - they have a Makefile.in, but no configure.ac.
> please ask them to include it, and do autoreconf before building
> (Probably they are not using autotools but they just like similar and
> confusing names)
Yes, they're using autotools-like names with hand-made stuff. Which is
why I have to do some flag injection by hand.
> - copyrights missing, e.g. Tommy Hofmann, Arb, FSFa
> licenses looks good to me
I gave another try at getting copyrights right.
> check-all-the-things:
> codespell --quiet-level=3
> flawfinder -Q -c .
> cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find
> or open any of the paths given.'
> [lots]
Uh... isn't that something more for upstream than for me?
> # You should almost never use -m64 and -m32 when compiling.
> $ grep -rE -- '-m64|-m32' .
> ./configure: ABI_FLAG="-m32"
> ./configure: ABI_FLAG="-m64"
See above : upstream has its own build system...
> $ pep8 --ignore W191 .
That's for upstream, isn't it?
> pyflakes{,3}
Again, that's for upstream.
> ./doc/source/_static/arbtext.pdf
> ./doc/source/_static/arbtext.eps
>
> maybe recreate during build?
Hmmm... the source appears to be the .svg ; I don't think I ship it in
the -doc package, so I don't think I should care. I'm not sure I'm eager
to put my hand in their doc-building yet...
> Please add some upstream metadata:
https://wiki.debian.org/UpstreamMetadata
Looks overkill at that point.
> and the other stuf LGTM
(you shouldn't address all the above, something is just nice to have)
I put up a new version both on git :
Vcs-Browser:
https://anonscm.debian.org/cgit/debian-science/packages/flint-arb.git
Vcs-Git:
https://anonscm.debian.org/git/debian-science/packages/flint-arb.git
and on mentors.d.n :
http://mentors.debian.net/package/flint-arb
dget -x
http://mentors.debian.net/debian/pool/main/f/flint-arb/flint-arb_2.8.1-1.dsc
Cheers,
Snark on #debian-science
