Hi dear maintainers
I agree with Jessie Rose Lee in that this bug remains in Jessie. I am using
backupninja 1.0.1-1.
I think I found & resolved the bug, but I'm no professional developer, and even
I know git and other tools, my knowledge about bug solution protocols is scarce
and theoretical.
So I'm not sure on how to proceed, please send me corrections if you deem it
for send this solution correctly.
I will quote to show my point. From BASH man page, in Arrays Section, you can
read "(...)Any element of an array may be referenced using ${name[subscript]}.
The braces are required to avoid conflicts with pathname expansion. If
subscript is @ or *, the word expands to all members of name. These subscripts
differ only when the word appears within double quotes. If the word is
double-quoted, ${name[*]} expands to a single word with the value of each array
member separated by the first character of the IFS special variable, and
${name[@]} expands each element of name to a separate word. When there are no
array members, ${name[@]} expands to nothing. If the double-quoted expansion
occurs within a word, the expansion of the first parameter is joined with the
beginning part of the original word, and the expansion of the last parameter is
joined with the last part of the original word. This is analogous to the
expansion of the special parameters * and @ (see Special Parameters above).
(...)"
>From /usr/share/backupninja/rsync I show lines 1130-1147, but inmediate
>interest is in lines 1139 & 1141:
for SECTION in $include; do
prepare_storage
set_orig
set_batch_mode
set_filelist
set_dest
info "Syncing $SECTION on $dest_path..."
debug $nice $rsync ${rsync_options[@]} $filelist_flag $excludes $batch_option
$orig $dest_path
set_pipefail
$nice su -c "$rsync ${rsync_options[@]} --delete-excluded $filelist_flag
$excludes $batch_option $orig $dest_path" | tee -a $log
check_rsync_exit_status $?
restore_pipefail
update_metadata
done
I replaced, in lines 1139 and 1141, expression
${rsync_options[@]}
by
${rsync_options[*]}
This is: because of its behaviour when in double quotes (as stated above in the
quoted excerpt of BASH man page), I changed the expansion character that
indicates the array to expand to all of its members. Since then, I can use the
rsync handler without any trouble. I not sure, but I think that other patch
proposed (bug #683371 in debian & backupninja bug #4019) will be unnecesary
with this correction.
Hoping that this can be helpful, best regards to all
--
Enrique Merle
Area Tecnologías
_______________________________________________
BIBHUMA Biblioteca Prof. Guillermo Obiols
Facultad de Humanidades y Ciencias de la Educación
Universidad Nacional de La Plata
Calle 51 entre 124 y 125 - Edificio B
ENSENADA (1925), Argentina
Telefax: +54-221-4230127 interno 1165
WEB: http://www.bibhuma.fahce.unlp.edu.ar
