Control: tags -1 wontfix * [email protected] <[email protected]> [2016-04-21 21:51 +0200]:
> Thanks for the links! > > I stumbled upon #2 yesterday before patching the source, but somehow I missed > #1. > #2 doesn't seem all that relevant to me, except for signaling that there might > or might not be some improvement coming from upstream in the long run. > #1 looks pretty similar to my patch. But this thread is from 2010 and dead, so > I don't expect that to be implemented anymore. > > bottom line: > Could you please include my patch in the Debian package until upstream comes > up > with something similar? Your "coding style" doesn't fit upstreams. Use tabs for the future. I've tested your patch a bit: - I am missing documentation. The manpage, the help and the config.example have to be adjusted. - It seems to work well on the filelist. But the format on different given playlists is not consistent. There are indents where they don't have to be. - It's a bit confusing if the id3 tags are numbered already. They even don't match the sorting every time. Respectively the filenames if they are numbered as well. This is on both the filelist and the playlist. (Well we have this phenomenon on the playlist anyway :( ) There is too much potential to get bugs. If there are any, they have to be fixed. I can't tell users to remove that feature if there is no feasible solution. Should say not maintainable. So no, I won't include your patch. And please consider that I won't test updated patches. You can publish your patch at the moc forum for further testing. You can use your patch at any time by yourself. Thanks for your contribution Elimar -- Excellent day for drinking heavily. Spike the office water cooler;-)
