Am Freitag, den 22.04.2016, 19:14 +0200 schrieb Axel Beckert: > Hi Tobias, > > Tobias Frost wrote: > > I've prepared an NMU for yt (versioned as 3.2.1-2.1). The diff > > is attached to this message. > > Thanks, appreciated! A few comments though: > > > + * Remove B-D on libpng (Closes: #810209) > > The diff doesn't contain changes in debian/control. Looks like they > were forgotten in the diff.
You're right, I did forget to include d/control. I'll do another iteration to fixing this mistake. (Reason for that: yt does not cleanup properly after build, so I nuked the build dir before final build and I did simply forgot to cp the modified d/control in place. Actually I should file that as a bug, too) > And you don't want to remove a B-D on libpng but one on libpng-dev. > I'd appreciate if you could be that precise in the changelog entry. Oversight from my side, I'm sorry. > > diff -Nru yt-3.2.1/debian/patches/try-to-fix-ftbs.patch yt- > > 3.2.1/debian/patches/try-to-fix-ftbs.patch > > --- yt-3.2.1/debian/patches/try-to-fix-ftbs.patch 1970-01-01 > > 01:00:00.000000000 +0100 > > +++ yt-3.2.1/debian/patches/try-to-fix-ftbs.patch 2016-04-22 > > 17:47:45.000000000 +0200 > > @@ -0,0 +1,50 @@ > > +Description: <short description, required> > > + <long description that can span multiple lines, optional> > > +Author: <name and email of author, optional> > > +Origin: https://bitbucket.org/yt_analysis/yt/commits/069715baac70d > > 5f0b186293b518eaf3802798370?at=yt > > + https://bitbucket.org/yt_analysis/yt/commits/3f7547299119397d1e2e > > 2baa1d42f809aef21e35 > > +Bug: <URL to the upstream bug report if any, implies patch has > > been forwarded, optional> > > +Bug-<Vendor>: <URL to the vendor bug report if any, optional> > > +Forwarded: <URL|no|not-needed, useless if you have a Bug field, > > optional> > > +Applied-Upstream: <version|URL|commit, identifies patches merged > > upstream, optional> > > +Reviewed-by: <name and email of a reviewer, optional> > > +Last-Update: <YYYY-MM-DD, last update of the meta-information, > > optional> > > Please either fill out this DEP3 template or remove it completely. > But > seeing a package uploaded with such completely useless dummy data > gives a very bad after-taste. > > Regards, Axel It has been fixed before upload, but after I sent nmudiff.
