Package: src:openuniverse
Version: 1.0beta3.1+dfsg-4
User: sanv...@debian.org
Usertags: binary-indep
Severity: important
Tags: patch

Hello Javier.

I tried to build this package with "dpkg-buildpackage -A"
(i.e. only architecture-independent packages), and it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep
   dh_testdir -i
   dh_update_autotools_config -i
   dh_auto_configure -i
        ./configure --build=x86_64-linux-gnu --prefix=/usr 
--includedir=\${prefix}/include --mandir=\${prefix}/share/man 
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var 
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu 
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode 
--disable-dependency-tracking
creating cache ./config.cache
checking for a BSD compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking whether make sets ${MAKE}... yes
checking for working aclocal... found
checking for working autoconf... found

[... snipped ...]

   debian/rules override_dh_install
make[1]: Entering directory '/<<BUILDDIR>>/openuniverse-1.0beta3.1+dfsg'
dh_install
[ ! -L debian/openuniverse/usr/share/openuniverse/conf/ou.conf ] && \
cd `pwd`/debian/openuniverse/usr/share/openuniverse/conf && \
        ln -s /etc/openuniverse.conf ou.conf
/bin/sh: 2: cd: can't cd to 
/<<BUILDDIR>>/openuniverse-1.0beta3.1+dfsg/debian/openuniverse/usr/share/openuniverse/conf
debian/rules:28: recipe for target 'override_dh_install' failed
make[1]: *** [override_dh_install] Error 2
make[1]: Leaving directory '/<<BUILDDIR>>/openuniverse-1.0beta3.1+dfsg'
debian/rules:14: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit 
status 2
--------------------------------------------------------------------------------

Explanation: We are creating arch-independent packages only, so the cd command 
fails
because debian/openuniverse/[...] does not exist (as openuniverse is 
arch-dependent).

The trivial fix is to override dh_install only when creating arch-dependent 
packages.

While we are at it, it would be more elegant to do the chgrp and chmod thing
just after dh_fixperms.

[ Another possible improvement would be to create symlinks with dh_link, or 
even better,
  using debian/openuniverse.links, but this is up to you ].

The following patch (warning: untested) might fix this.

BTW: Glad that you finally decided to use UTF-8 for your own name :-)

Thanks.


--- a/debian/rules
+++ b/debian/rules
@@ -24,7 +24,7 @@ override_dh_auto_build:
        $(MAKE)
 
 
-override_dh_install:
+override_dh_install-arch:
        dh_install
        [ ! -L debian/openuniverse/usr/share/openuniverse/conf/ou.conf ] && \
        cd `pwd`/debian/openuniverse/usr/share/openuniverse/conf && \
@@ -32,7 +32,8 @@ override_dh_install:
        [ ! -L debian/openuniverse/usr/share/doc/openuniverse/manual ] && \
        cd debian/openuniverse/usr/share/doc/openuniverse && \
                ln -s ../../openuniverse/docs manual 
+
+override_dh_fixperms-arch:
+       dh_fixperms
        chgrp games `pwd`/debian/openuniverse/var/games/openuniverse/scrshots
        chmod g+ws  `pwd`/debian/openuniverse/var/games/openuniverse/scrshots
-
-

Reply via email to