Bug#807208: Various bugs in /etc/init.d/tahoe-lafs

[Ramakrishnan Muthukrishnan]

Sébastien Béhuret <sbehu...@gmail.com> writes:

> Package: tahoe-lafs
> Version: 1.10.2-2
> Tags: patch
>
>
> Dear Maintainer,
>
> There are a couple of bugs in /etc/init.d/tahoe-lafs:
>
> - When AUTOSTART is set to "none", the initscript attempts to start the
> node “/var/lib/tahoe-lafs/none”.
> - When AUTOSTART lists a non-existing node, the initscript attempts to
> start it.
> - When a node is not owned by any existing user (node with an uid but
> without an username), stat -c %U returns "UNKNOWN".
>
> The attached patch resolves these issues. However, for the third issue, it
> may be a good idea to allow starting nodes that are not owned by a regular
> user, perhaps by using sudo -u '#uid' -g '#uid' instead of su.

Dear Sebastien,

Sorry for a very late response to this bug. Thanks a lot for the report.

For the first two points, I tried to solve the issue by exiting
immediately. Do you think that will work?

diff --git a/debian/tahoe-lafs.init b/debian/tahoe-lafs.init
index 27a614b..548d77a 100755
--- a/debian/tahoe-lafs.init
+++ b/debian/tahoe-lafs.init
@@ -77,6 +77,7 @@ start|stop|restart)
     if [ $# -eq 0 ]; then
         if [ "$AUTOSTART" = "none" ] || [ -z "$AUTOSTART" ]; then
             log_warning_msg " Autostart disabled."
+            exit 0
         fi
         if [ "$AUTOSTART" = "all" ]; then
             # all nodes shall be taken care of automatically


Thanks
Ramakrishnan

signature.asc
Description: PGP signature