On Mon, May 2, 2016 at 9:21 PM, Tormod Volden <[email protected]> wrote: > The "offending" code is: > > # if defined _POSIX_SOURCE || defined _POSIX_C_SOURCE || defined > _XOPEN_SOURCE > /* PTHREAD_STACK_MIN needs the above test. */ > assert(stacksize >= PTHREAD_STACK_MIN); > # endif > PTHREAD_VERIFY(pthread_attr_setstacksize(&attr, stacksize)); > > Maybe we should simply skip the above assert on Hurd. The real minimum > on Hurd is much smaller than on Linux and any stacksize asked for here > should be larger. > > https://github.com/ArneBab/hurd-web/blob/master/hurd/porting/guidelines.mdwn#-pthread_stack_min- >
Can you (or anyone on Hurd) please verify that this patch fixes the issue, and that the package now builds successfully? Regards, Tormod
# # To be sent upstream (jwz) after verification # # PTHREAD_STACK_MIN is not defined on GNU/Hurd # http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823049 # Index: xscreensaver-git/utils/thread_util.c =================================================================== --- xscreensaver-git.orig/utils/thread_util.c 2016-05-07 23:25:54.144471652 +0200 +++ xscreensaver-git/utils/thread_util.c 2016-05-07 23:27:27.668767526 +0200 @@ -960,7 +960,7 @@ attr_ptr = &attr; if(pthread_attr_init(&attr)) return NULL; -# if defined _POSIX_SOURCE || defined _POSIX_C_SOURCE || defined _XOPEN_SOURCE +# if (defined _POSIX_SOURCE || defined _POSIX_C_SOURCE || defined _XOPEN_SOURCE) && !defined __GNU__ /* PTHREAD_STACK_MIN needs the above test. */ assert(stacksize >= PTHREAD_STACK_MIN); # endif
