On 2015-11-24 11:39:08, Robert Edmonds wrote:
> David Matthew Mattli wrote:
> > So now it checks for either SOLARIS_64BIT_ENABLED or __LP64__ to 
> > determine whether the sparc platform is 64bit. With this change the package
> > builds on my sparc64 system and it shouldn't affect any other archs.
> > 
> > I've attached a patch to implement this change.
> 
> Hi, David:
> 
> Thank you for this patch, but it looks like a very similar patch was
> applied upstream against protobuf 3:
> 
>     https://github.com/google/protobuf/pull/780
> 
> (Upstream is no longer developing the 2.x branch.)
> 
> I'm not sure when protobuf 3 is going to hit unstable, but if this bug
> is critical for the sparc64 efforts I think we might be able to make

I'll include this patch in the upcoming 2.6.1-2 upload. Upstream has
rejected that pull request, as they had a different (better?) change to
support sparc64. Given that I don't know all the implications of that
patch
(https://github.com/google/protobuf/commit/97fa4ca1565d216d102af9510b17966c28c7a52a),
I'll just apply this patch until we package 3.x (that commit is included
after 3.0.0 beta 1).

thanks!
iustin

Attachment: signature.asc
Description: PGP signature

Reply via email to