Package: bubblewrap
Version: 0~git160513-3
Severity: minor
Tags: patch

bubblewrap is currently Section: web, which seems wrong: it isn't a web
server or client. I would suggest Section: admin, like flatpak and sudo;
does that seem like the best Section to you?

The Priority should probably also be optional, since the gnome metapackage
is somewhat likely to depend on bubblewrap in future, via the dependency
chain gnome -> gnome-software -> flatpak -> bubblewrap.

To fix this fully, after agreeing on a correct Section and Priority,
we'll need to report a ftp.debian.org bug asking for the ftp-masters
to correct the override file. I'm happy to open that bug.

I've also made some other minor fixes, also attached:

* debian/copyright contains some copy/paste errors
* I think the package should be Architecture: linux-any like flatpak,
  since it uses Linux-specific syscalls and namespacing/container features

Patches are attached, and also available in git here:

    ssh://git.debian.org/git/users/smcv/bubblewrap.git

Because it's closely linked to flatpak, I would like to co-maintain this
package, preferably by copying that git repository into collab-maint git.

Regards,
    S
>From 396fa8dd21697c4bf270f638a4ce074ee4661902 Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Sat, 21 May 2016 15:11:41 +0100
Subject: [PATCH 1/7] debian/copyright: correct package name and source

---
 debian/changelog | 6 ++++++
 debian/copyright | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 558a546..fe333b9 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+bubblewrap (0~git160513-3) UNRELEASED; urgency=medium
+
+  * debian/copyright: correct package name and source
+
+ -- Simon McVittie <s...@debian.org>  Sat, 21 May 2016 15:10:56 +0100
+
 bubblewrap (0~git160513-2) unstable; urgency=low
 
   * Install bwrap binary setuid (closes: #824646).
diff --git a/debian/copyright b/debian/copyright
index ef1f2a3..6d5d6de 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,6 +1,6 @@
 Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
-Upstream-Name: paxctld
-Source: https://grsecurity.net
+Upstream-Name: bubblewrap
+Source: https://github.com/projectatomic/bubblewrap/
 
 Files: *
 Copyright: 2016 Alexander Larsson
-- 
2.8.1

>From 45f959a53569679dbf766a48d0296b5aab9c30ca Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Sat, 21 May 2016 15:14:14 +0100
Subject: [PATCH 2/7] debian/control: make the whole package Linux-only

Like Flatpak, this package is inherently non-portable.
---
 debian/changelog | 2 ++
 debian/control   | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index fe333b9..3fa6392 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,8 @@
 bubblewrap (0~git160513-3) UNRELEASED; urgency=medium
 
   * debian/copyright: correct package name and source
+  * debian/control: make the whole package Linux-only. Like Flatpak, this
+    package is inherently non-portable.
 
  -- Simon McVittie <s...@debian.org>  Sat, 21 May 2016 15:10:56 +0100
 
diff --git a/debian/control b/debian/control
index 21a4806..0198270 100644
--- a/debian/control
+++ b/debian/control
@@ -2,12 +2,12 @@ Source: bubblewrap
 Section: web
 Priority: extra
 Maintainer: Laszlo Boszormenyi (GCS) <g...@debian.org>
-Build-Depends: debhelper (>= 9), dh-autoreconf, pkg-config, libselinux1-dev (>= 2.1.9) [linux-any], libcap-dev, bash-completion, xsltproc, docbook-xsl
+Build-Depends: debhelper (>= 9), dh-autoreconf, pkg-config, libselinux1-dev (>= 2.1.9), libcap-dev, bash-completion, xsltproc, docbook-xsl
 Standards-Version: 3.9.8
 Homepage: https://github.com/projectatomic/bubblewrap
 
 Package: bubblewrap
-Architecture: any
+Architecture: linux-any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Description: setuid wrapper for unprivileged chroot and namespace manipulation
  Core execution engine for unprivileged containers that works as a setuid
-- 
2.8.1

>From f09d06ad3f76acaed755bd037fc0a757cea7e9a2 Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Sat, 21 May 2016 15:27:06 +0100
Subject: [PATCH 3/7] Move from Section: web to Section: admin

---
 debian/changelog | 1 +
 debian/control   | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 3fa6392..2d464a3 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,6 +3,7 @@ bubblewrap (0~git160513-3) UNRELEASED; urgency=medium
   * debian/copyright: correct package name and source
   * debian/control: make the whole package Linux-only. Like Flatpak, this
     package is inherently non-portable.
+  * Move from Section: web to Section: admin
 
  -- Simon McVittie <s...@debian.org>  Sat, 21 May 2016 15:10:56 +0100
 
diff --git a/debian/control b/debian/control
index 0198270..e0ad3d5 100644
--- a/debian/control
+++ b/debian/control
@@ -1,5 +1,5 @@
 Source: bubblewrap
-Section: web
+Section: admin
 Priority: extra
 Maintainer: Laszlo Boszormenyi (GCS) <g...@debian.org>
 Build-Depends: debhelper (>= 9), dh-autoreconf, pkg-config, libselinux1-dev (>= 2.1.9), libcap-dev, bash-completion, xsltproc, docbook-xsl
-- 
2.8.1

>From 31b48b2dfcb64c1f4fa4db2940cecc557b908500 Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Sat, 21 May 2016 15:28:17 +0100
Subject: [PATCH 4/7] Increase Priority to optional

This tool is likely to be depended on by gnome-software (via Flatpak) in
future.
---
 debian/changelog | 2 ++
 debian/control   | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 2d464a3..e85d381 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,8 @@ bubblewrap (0~git160513-3) UNRELEASED; urgency=medium
   * debian/control: make the whole package Linux-only. Like Flatpak, this
     package is inherently non-portable.
   * Move from Section: web to Section: admin
+  * Increase Priority to optional, because this tool is likely to be
+    depended on by gnome-software (via Flatpak) in future
 
  -- Simon McVittie <s...@debian.org>  Sat, 21 May 2016 15:10:56 +0100
 
diff --git a/debian/control b/debian/control
index e0ad3d5..e43e10e 100644
--- a/debian/control
+++ b/debian/control
@@ -1,6 +1,6 @@
 Source: bubblewrap
 Section: admin
-Priority: extra
+Priority: optional
 Maintainer: Laszlo Boszormenyi (GCS) <g...@debian.org>
 Build-Depends: debhelper (>= 9), dh-autoreconf, pkg-config, libselinux1-dev (>= 2.1.9), libcap-dev, bash-completion, xsltproc, docbook-xsl
 Standards-Version: 3.9.8
-- 
2.8.1

Reply via email to