tags 824842 + patch thanks On Fri, May 20, 2016 at 01:37:12PM +0100, Martín Ferrari wrote: > Makes sense. For sysvinit I am making it wait almost 20 seconds, and > after that the action just fails (instead of SIGKILLing it). If systemd > does not have that option, I would say wait up to one minute. > > Care to send a patch? I don't use systemd, so I have no clue about it :)
for sure! The attached patch would make it match sysvinit behaviour. thanks, filippo -- http://esaurito.net - 0x99D49B6B00CAD1E5 - ⠠⠵
diff --git a/debian/changelog b/debian/changelog index c36583a..f4257bc 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,8 +1,13 @@ prometheus (0.18.0+ds-3) UNRELEASED; urgency=medium + [ Martín Ferrari ] * Switch to use the golang-github-prometheus-client-model-dev package. * Improve the way datetimepicker is built. + [ Filippo Giunchedi ] + * debian/service: match sysvinit behaviour (send SIGTERM with 20s timeout, + never send SIGKILL) Closes: #824842 + -- Martín Ferrari <[email protected]> Sun, 08 May 2016 04:33:32 +0000 prometheus (0.18.0+ds-2) unstable; urgency=medium diff --git a/debian/service b/debian/service index 44ba6fb..067448a 100644 --- a/debian/service +++ b/debian/service @@ -8,6 +8,8 @@ User=prometheus EnvironmentFile=/etc/default/prometheus ExecStart=/usr/bin/prometheus $ARGS ExecReload=/bin/kill -HUP $MAINPID +TimeoutStopSec=20s +SendSIGKILL=no [Install] WantedBy=multi-user.target
