On 06/25/2016 02:16 AM, Ritesh Raj Sarraf wrote: > On Thu, 2016-06-23 at 16:50 -0600, Andrew Patterson wrote: >> +# Save boot > setting for aio-max-nr. >> +BOOT_AIO_MAX_NR=$(cat /proc/sys/fs/aio-max-nr) >> + >> if [ -f /etc/multipath-tools-boot.conf ]; then >> . /etc/multipath-tools-boot.conf >> else >> MULTIPATH_TOOLS_MODULES="dm-mod dm-multipath" >> + MULTIPATH_TOOLS_MIN_AIO_MAX_NR=$BOOT_AIO_MAX_NR >> fi >> > > I'd let the user define the AIO_MAX value explicitly in /etc/default/multipath- > tools. And use the sysctl/procfs option as a fallback. > > What do you say ? > >
That was where I went initially, but I thought that means that the user now needs to configure aio-max-nr in two places, once in sysctl.conf and once in /etc/default/multipath-tools (for when running multipath tools by hand or in scripts). I thought this solution resulted in less overall system configuration. The /etc/default/multipath-tools is more explicit, so it does have advantages too. Andrew -- Andrew Patterson Hewlett-Packard Enterprise
