Source: shadowsocks-libev
Version: 2.4.7+20160630+ds-1
Severity: important
Justification: fails to build from source

Builds of shadowsocks-libev on alpha and hppa have been failing:

  utils.c:1:0: error: -fstack-protector not supported for this target [-Werror]

It looks like this instance of -fstack-protector comes from upstream's
build system, which doesn't account for these architectures' lack of
support for it.  Moreover, on the remaining architectures, dpkg-buildflags
already supplies -fstack-protector-strong, so -fstack-protector either is
redundant or results in less strong protection.

Ideally, upstream's build system would test that -fstack-protector
actually works, rather than hardcoding a list of architectures on which
it's expected to.  (It would be even better if the build system got out of
the way if it noticed -fstack-protector or -fstack-protector-strong
already in CFLAGS.)

As it is, I would suggest unconditionally configuring with --disable-ssp
and deferring to dpkg-buildflags.

Could you please take a look?

Thanks!

Reply via email to