Control: found -1 2:3.3.12-1
Control: tags -1 + patch

On 2016-07-02 02:01 +0000, Craig Small wrote:

> tag 827423 pending
> thanks
>
> Hello,
>
> Bug #827423 reported by you has been fixed in the Git repository. You can
> see the changelog below, and you can check the diff of the fix at:
>
>     http://git.debian.org/?p=collab-maint/procps.git;a=commitdiff;h=470320f
>
> ---
> commit 470320fc76a7c278ead02d1900f92f73740bafd9
> Author: Craig Small <[email protected]>
> Date:   Sat Jul 2 11:59:12 2016 +1000
>
>     Dont run init on install
>     
>     Sometimes on install or upgrade the sysctl part fails. The kernel
>     variable should be installed at startup time, not some arbitarily
>     time afterwards (and over and over).
>     
>     Closes: #827423

Unfortunately this fix does not work, since there was already an
existing override for dh_installinit which overrides (no pun intended)
the one you committed here.  Seen on the build logs:

,----
| debian/rules:98: warning: overriding recipe for target 
'override_dh_installinit'
| debian/rules:54: warning: ignoring old recipe for target 
'override_dh_installinit'
`----

Here is a patch to remove the second override.  I think it does not
matter whether dh runs dh_installinit on non-Linux architectures since
there is no init script there anyway, so it's a no-op.

--8<---------------cut here---------------start------------->8---
diff --git a/debian/rules b/debian/rules
index 944809f..0534f9d 100755
--- a/debian/rules
+++ b/debian/rules
@@ -93,11 +93,6 @@ endif
 override_dh_installchangelogs:
        dh_installchangelogs NEWS
 
-override_dh_installinit:
-ifeq ($(DEB_HOST_ARCH_OS), linux)
-       dh_installinit 
-endif
-
 override_dh_makeshlibs:
        dh_makeshlibs -V 'libprocps6'
 
--8<---------------cut here---------------end--------------->8---

Cheers,
       Sven

Reply via email to