Package: gdebi
Version: 0.9.5.7
Severity: normal
Tags: patch

Hi,

Could you please drop the dependency against gnome-icon-theme?
gnome-icon-theme is deprecated for gtk3 and replaced by
adwaita-icon-theme.

If I'm not wrong, gedebi only uses one icon from gnome-icon-theme,
gnome-mime-application-x-deb, this icon is not available in
adwaita-icon-theme. BUT, can be replaced by the package-x-generic (which
is also available in other icon themes).

On my machine this is the same icon as for the .deb and .udeb files.

An explicit dependency against adwaita-icon-theme should probably be
avoided as libgtk3 will already pull it

Cheers,

Laurent Bigonville

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages gdebi depends on:
ii  gdebi-core        0.9.5.7
ii  gir1.2-gtk-3.0    3.20.6-2
ii  gir1.2-vte-2.91   0.44.2-1
ii  gksu              2.0.2-9
ii  gnome-icon-theme  3.12.0-2
ii  python3-gi        3.20.1-1
pn  python3:any       <none>

Versions of packages gdebi recommends:
ii  libgtk2-perl      2:1.2498-3
ii  lintian           2.5.45
ii  shared-mime-info  1.6-1

gdebi suggests no packages.

-- no debconf information
diff -Nru gdebi-0.9.5.7/data/gdebi.desktop.in gdebi-0.9.5.7bigon1/data/gdebi.desktop.in
--- gdebi-0.9.5.7/data/gdebi.desktop.in	2015-07-02 09:14:35.000000000 +0200
+++ gdebi-0.9.5.7bigon1/data/gdebi.desktop.in	2016-07-14 00:05:12.000000000 +0200
@@ -3,7 +3,7 @@
 _GenericName=Package Installer
 _Comment=Install and view software packages
 Exec=gdebi-gtk %f
-Icon=gnome-mime-application-x-deb
+Icon=package-x-generic
 Terminal=false
 Type=Application
 Categories=System;
diff -Nru gdebi-0.9.5.7/debian/control gdebi-0.9.5.7bigon1/debian/control
--- gdebi-0.9.5.7/debian/control	2015-01-29 15:00:39.000000000 +0100
+++ gdebi-0.9.5.7bigon1/debian/control	2016-07-13 23:55:05.000000000 +0200
@@ -46,8 +46,7 @@
          gir1.2-gtk-3.0,
          gir1.2-vte-2.91,
          python3-gi,
-         gksu,
-         gnome-icon-theme
+         gksu
 Recommends: libgtk2-perl, shared-mime-info, lintian
 Description: simple tool to view and install deb files - GNOME GUI
  gdebi lets you install local deb packages resolving and installing
diff -Nru gdebi-0.9.5.7/GDebi/GDebiGtk.py gdebi-0.9.5.7bigon1/GDebi/GDebiGtk.py
--- gdebi-0.9.5.7/GDebi/GDebiGtk.py	2015-07-08 15:29:23.000000000 +0200
+++ gdebi-0.9.5.7bigon1/GDebi/GDebiGtk.py	2016-07-14 00:05:35.000000000 +0200
@@ -80,7 +80,7 @@
         # use a nicer default icon
         icons = Gtk.IconTheme.get_default()
         try:
-          logo=icons.load_icon("gnome-mime-application-x-deb", 48, 0)
+          logo=icons.load_icon("package-x-generic", 48, 0)
           if logo != "":
             Gtk.Window.set_default_icon_list([logo])
         except Exception as e:

Reply via email to