Dear Gianfranco, thank you for the patch, it should do the right thing.
I have implemented these fixes for GCC6 with slight modifications in the Odin SVN to avoid problems on other platforms (VxWorks, Visual Studio).
T. Am 16.07.2016 um 09:55 schrieb Gianfranco Costamagna:
Hi, attached the patch updated for gcc-6 (addition of the incomplete upstream one) and the complete debdiff for a building oding against gcc-6 basically the new issues (excluding the already upstream-patched "odinseq/odinpulse.cpp" were: in odinseq/seqgradspiral.cpp bad compare between double and float - max_grad_diff=STD_max(double(max_grad_diff),fabs(tds.Gx-last_Gx)); - max_grad_diff=STD_max(double(max_grad_diff),fabs(tds.Gy-last_Gy)); + max_grad_diff=STD_max(max_grad_diff,fabs(tds.Gx-last_Gx)); + max_grad_diff=STD_max(max_grad_diff,fabs(tds.Gy-last_Gy)); - max_grad_magn=STD_max(double(max_grad_magn),fabs(tds.Gx)); - max_grad_magn=STD_max(double(max_grad_magn),fabs(tds.Gy)); + max_grad_magn=STD_max(max_grad_magn,fabs(tds.Gx)); + max_grad_magn=STD_max(max_grad_magn,fabs(tds.Gy)); and in cmdline-utils/swab.cpp ifstream return check - if(in_data == NULL) { + if(in_data.fail()) { - if(out_data == NULL) { + if(out_data.fail()) { - if(out_data == NULL) { + if(out_data.fail()) { they seem to be correct to me, but I'm ccing upstream to be sure :) BTW, in deferred/5. thanks, G.