Control: tags -1 + patch

On 2016-07-20 09:45 +0200, Sven Joachim wrote:

> Package: ne
> Version: 3.0.1-2+b1
> Severity: minor
> User: [email protected]
> Usertags: libncurses5-dependency
>
> The ne binary is linked with ncurses, although it only uses functions
> from tinfo.  This causes an unnecessary dependency on libncurses5, as
> can be seen in the build logs:
>
> ,----
> |    dh_shlibdeps -a
> | dpkg-shlibdeps: warning: package could avoid a useless dependency if
> | debian/ne/usr/bin/ne was not linked against libncurses.so.5 (it uses
> | none of the library's symbols)
> `----
>
> The solution is to link with -ltinfo rather than -lcurses in
> src/makefile.  Will send a patch as soon as I have the bug number.

Attached here, ready to be dropped into debian/patches.  Note that it
must be placed after 01_Fix_ftbfs_add_lm.diff in the series file, since
that patch touches the same line of src/makefile.

Cheers,
       Sven

Description: Link with tinfo rather than curces
Author: Sven Joachim <[email protected]>
Bug-Debian: https://bugs.debian.org/831852
Last-Update: 2016-07-20

---

--- ne-3.0.1.orig/src/makefile
+++ ne-3.0.1/src/makefile
@@ -96,7 +96,7 @@ CFLAGS+=$(OPTS) $(GCCFLAGS) \
 	$(if $(NE_ANSI),    -DTERMCAP -DANSI,)
 
 
-LIBS=$(if $(NE_TERMCAP)$(NE_ANSI),,-lcurses -lm)
+LIBS=$(if $(NE_TERMCAP)$(NE_ANSI),,-ltinfo -lm)
 
 ne:	$(OBJS) $(if $(NE_TERMCAP)$(NE_ANSI),$(TERMCAPOBJS),)
 	$(CC) $(OPTS) $(LDFLAGS) $(if $(NE_TEST), -coverage -lefence,) $^ -lm $(LIBS) -o $(PROGRAM)

Reply via email to