2016-08-03 21:11 GMT+08:00 Chris Lamb <la...@debian.org>: >> The original author used os.getenv() in python argparse, so the output >> of `mini-buildd --help' really depend on $HOME env var > > I agree that upstream are using an environment variable called HOME and > note that it ends up in the manpage. > > However, this does not imply that the string "$HOME" will be interpolated, > so your patch breaks mini-buildd.
Sorry, it is indeed my mistake. > What's wrong with my expanduser suggestion? > > Patch attached. If we need to expand earlier or later, what is the difference between current situation and patched version? Home directory will eventually expand to difference strings due to different $HOME env var, and the package will be unreproducible. Also, this patch should not be alone, since we need to add os.path.expanduser() somewhere else. > ... patch the callsites to use os.path.expanduser at "real" runtime How do we know if the script is running at "real" runtime? Thanks, Boyuan
