Package: fake-hwclock
Version: 0.8
Severity: normal
Tags: patch

Any configuration settings added to /etc/default/fake-hwclock are not utilised 
by the primary fake-hwclock script.

The problem appears to be two-fold.  Firstly, the environment variable present 
in the parameter file are loaded but not passed to the fake-hwclock script by 
the /etc/init.d script,
as the "bin" script is not called with "source" (or ".").  Secondly, the 
fake-hwclock "binary" call made by cron.hourly does not call the parameter file 
at all.

We've solved this issue by moving the parameter file call from the init.d 
script into the "binary" script.

We discovered this issue whilst attempting to use a data file other than 
/etc/fake-hwclock.data (and yes, we've read bug #782314 and note the 
recommendations against doing so).

-- System Information:
Debian Release: 7.8
Architecture: armhf (armv7l)

Kernel: Linux 4.4.11-v7+ (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages fake-hwclock depends on:
ii  init-system-helpers  1.18~bpo70+1

fake-hwclock recommends no packages.

Versions of packages fake-hwclock suggests:
ii  cron [cron-daemon]  3.0pl1-124
ii  ntp                 1:4.2.6.p5+dfsg-2+deb7u3

-- Configuration Files:
/etc/default/fake-hwclock changed [not included]
/etc/init.d/fake-hwclock changed [not included]

-- no debconf information
--- etc/init.d/fake-hwclock.orig	2016-08-11 07:57:12.000000000 +1000
+++ etc/init.d/fake-hwclock	2016-08-11 07:20:04.000000000 +1000
@@ -17,11 +17,6 @@ set -e
 # Include core init functions if needed
 . /lib/lsb/init-functions
 
-PARAM=/etc/default/fake-hwclock
-if [ -f $PARAM ]; then
-    . "$PARAM"
-fi
-
 case "${1:-}" in
   stop|reload|restart|force-reload)
         echo "Stopping fake hwclock: saving system time."
--- sbin/fake-hwclock.orig	2016-08-11 07:56:28.000000000 +1000
+++ sbin/fake-hwclock	2016-08-11 07:19:37.000000000 +1000
@@ -10,6 +10,11 @@
 #
 # License: GPLv2, see COPYING
 
+PARAM=/etc/default/fake-hwclock
+if [ -f $PARAM ]; then
+    . "$PARAM"
+fi
+
 if [ "$FILE"x = ""x ] ; then
     FILE=/etc/fake-hwclock.data
 fi

Reply via email to