On Thu, 11 Aug 2016 at 19:50:47 +0200, Matthias Klumpp wrote:
> Why should I add patches which only apply if the project is compiled
> without YAML support
I thought I'd sent that change upstream, but not to this bug?
> and without GPerf support, which never happens in Debian?
I don't see a build-dependency on gperf (unless you added one in 0.5.17-1),
and the symbols file doesn't seem to mention the extra symbols that would
appear if it was present?
The issue I had in the non-Debian environment was that I was
rebuilding the Debian package in an unclean environment (a fairly
complete "SDK" virtual machine) which *did* have gperf, and the ABI
changed.
If you want the better performance of using a perfect hash function,
please apply my gperf patch so that the next upstream release won't
be an ABI break, and then build-depend on gperf.
> For the AudioVideo thing, I don't know if this will interfere with
> GNOME Software, because it was once added because GS couldn't handle
> AudioVideo due to some design choices (not sure if that's resolved by
> now).
I can see that this could plausibly be bad for current gnome-software
(3.20). The author of appstream-glib is also the maintainer of
gnome-software and has applied the patch upstream, so he clearly doesn't
think it's going to be a problem for 3.21. I'm currently using a 3.21
snapshot (I wanted to try out its Flatpak support) but I'll downgrade to
3.20 with a patched appstream-glib, and check that Rhythmbox and Totem
appear in the correct places.
There is one more patch that I proposed but you haven't either applied or
discussed here, "as_store_from_file_internal: set up path data for the
file itself" (which is related to and depends on the one you applied,
"don't redundantly monitor files"). The bug that this patch fixes is
that if you use as_store_from_file() to add a specific xml.gz file in
a directory that is not otherwise monitored, then touch that file, the
library will issue a warning and not actually update it. I realise this
is quite a niche usage, so if you want to wait for an upstream release
that contains it, that's fine of course.
Thanks,
S
