Hi, on Friday the upstream author released a new version and so I spent a good part of the weekend packaging. ;-)
I uploaded the package at mentors.debian.net : https://mentors.debian.net/package/audio-recorder But I've got a lot of questions and I hope you can help me: 1) lintian reports an error: source-contains-unsafe-symlink, referring to the po/Makefile.in.in which is a symlink to /usr/share/intltool/Makefile.in.in . It seems to me that this symlink is intended. Even more since there is a --copy option for intltoolize to copy such files instead of creating a symlink. See [1]. I am not sure what is best practice here. I found some patches for other programs where they just copy the Makefile.in.in file to satisfy lintian. Should I also do this? 2) dpkg-shlibdeps gives me several warnings of the form "package could avoid a useless dependency if binary was not linked against *library* (it uses none of the *library*'s symbols)". For libgthread, libpangocairo, libdbusmenu-glib, libatk, libcairo-gobject, libpango, libdbus as *library*. I guess these libraries are automatically linked because the makefile uses some variables like GLIB_LIBS, GTHREAD_LIBS, etc which probably include libraries that or not necessarily needed. Aren't those libraries that are always available in a GNOME environment? Do I have to do something about this warnings? 3) I deleted the upstream debian directory at the beginning. That means it is not even included in the orig.tar.gz . I wanted to avoid any conflicts. Is that OK? I want to ask the upstream maintainer if he could provide a tar.gz without the his debian directory in the future. He seems to be a nice person, so probably he will do this. 4) I changed the version from 1.8+0 to 1.8-0 after I had problems with dh_make. I think the hyphen is more or less reserved. In upstream tarball it separates name and version and in the Debian version it it is for the revision. I am just not sure if replacing it by a plus sign is best practice. What do you think? And should I ask the upstream maintainer to change his versioning scheme? I also replaced the version in configure.ac, so it is also replaced in the binary. 5) I did not know how to make the watch file work. Because at the moment, the launchpad site [2] is not updated anymore, so I had to pick the tar.gz manually from the ppa. Maybe the easiest is to ask the maintainer to update that site at least when he releases a new version. 6) I wanted to change http to https wherever possible, but I was not sure where I have to. Now I only did it in the po file strings. I did not change it in source files or automatically generated files. 7) When running check-all-the-things there where a lot of warnings more. But I think what is left over is not important for this case. Still I wanted to mention it. Yours David [1] http://manpages.ubuntu.com/manpages/trusty/man8/intltoolize.8.html [2] https://launchpad.net/audio-recorder
signature.asc
Description: OpenPGP digital signature
