Package: geeqie Version: 1:1.2-3 Followup-For: Bug #783262 Hi.
Firstly, thank you for maintaining geeqie in Debian. It is appreciated. I also suffer from what I believe is this bug. It was not present in geeqie 1.0 and was simple for me to reproduce in 1.2+. I open a directory containing a few thousand jpg files of around 100k each and just keep hitting the key for "Next Image". After around a minute my computer will freeze. Given this reproducibility, I ran git bisect and found the commit that introduced the behaviour for me was the following commit b4c4a924121c3aa6b2f1eb7570dd3f419d2f4d83 Author: Vladimir Nadvornik <nadvor...@suse.cz> Date: Thu Aug 2 00:15:16 2012 +0200 use cairo for drawing I then noticed what I think is a missing cairo_destroy call in cellrenderericon.c . The following patch solves the problem completely for me as far as I can tell: diff -Nru geeqie-1.2.old/src/cellrenderericon.c geeqie-1.2/src/cellrenderericon.c --- geeqie-1.2.old/src/cellrenderericon.c 2014-07-20 14:16:02.000000000 +0100 +++ geeqie-1.2/src/cellrenderericon.c 2016-08-19 03:40:27.387539295 +0100 @@ -663,7 +663,10 @@ pixbuf = cellicon->pixbuf; text = cellicon->text; - if (!pixbuf && !text) return; + if (!pixbuf && !text) { + cairo_destroy(cr); + return; + } gtk_cell_renderer_get_padding(cell, &xpad, &ypad); Please let me know if you agree with my conclusions. If so it would be nice to have this patch included. Kind regards, Michael Cross -- System Information: Debian Release: 8.5 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages geeqie depends on: ii geeqie-common 1:1.2-3 ii libatk1.0-0 2.14.0-1 ii libc6 2.19-18+deb8u4 ii libcairo2 1.14.0-2.1+deb8u1 ii libexiv2-13 0.24-4.1 ii libfontconfig1 2.11.0-6.3+deb8u1 ii libfreetype6 2.5.2-3+deb8u1 ii libgcc1 1:4.9.2-10 ii libgdk-pixbuf2.0-0 2.31.1-2+deb8u5 ii libglib2.0-0 2.42.1-1+b1 ii libgtk2.0-0 2.24.25-3+deb8u1 ii libjpeg62-turbo 1:1.3.1-12 ii liblcms2-2 2.6-3+b3 ii liblircclient0 0.9.0~pre1-1.2 ii liblua5.1-0 5.1.5-7.1 ii libpango-1.0-0 1.36.8-3 ii libpangocairo-1.0-0 1.36.8-3 ii libpangoft2-1.0-0 1.36.8-3 ii libstdc++6 4.9.2-10 ii libtiff5 4.0.3-12.3+deb8u1 Versions of packages geeqie recommends: pn exiftran <none> pn exiv2 <none> ii imagemagick 8:6.8.9.9-5+deb8u3 ii librsvg2-common 2.40.5-1+deb8u2 pn lpr <none> pn ufraw-batch <none> pn zenity <none> Versions of packages geeqie suggests: pn geeqie-dbg <none> pn gimp <none> pn libjpeg-progs <none> pn ufraw <none> pn xpaint <none> -- no debconf information