On Sat, 28 May 2016 10:34:02 +0300, Niko Tyni wrote: > not ok 700 - Frozen data matches parse result for 'Java/1.6.0_21' -> > generic_name_version -> 233 > [...] > Test Summary Report > ------------------- > t/02-parser.t (Wstat: 256 Tests: 754 Failed: 1) > Failed test: 700 > Non-zero exit status: 1
The upstream bug links to https://gist.github.com/dagolden/9559280 which explains that version->numify() doesn't treat underscores as a tuple separator anymore but simply ignores them. What we have here is: - raw version: 1.6.0_21 - old version->numify: 1.006000_021 = expected by test currently - new version->numify: 1.006021 What we can do is (both tested): - Change the _numify function in lib/Parse/HTTP/UserAgent.pm to replace "_" with "." like it's done with "-" (and other things). Then version->numify ends up with 1.006000021 with old and new version.pm. This of course needs a change of the expected value in t/data/robot/1 as well. This leads to a consistend result for versions with underscores but a new one. - Mark the 'Java/1.6.0_21' in t/data/robot/1 as TODO. Less invasive but leads to different results for underscore versions depending on the version.pm version. Not sure which option is better from a user perspective ... Cheers, gregor -- .''`. Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Rolling Stones
signature.asc
Description: Digital Signature
