Hello, On Wed, Aug 24, 2016 at 09:09:31AM +0800, Boyuan Yang wrote: > Thank you for your advice. I will not force-push commits from now on.
Cool, thanks :) > > (I can obtain the tarball from mentors, but you might consider > > adding it to your git repository using pristine-tar(1).) > > Since it is a debian-source (ds) package, I am not sure which original tarball > should be provided with pristine-tar. Anyway, I put both the ds-modified and > the original tarball with pristine-tar inside now. (Check the > pristine-tar branch.) I meant the tarball that you want to have uploaded to Debian. > FYI, this software is debian-sourced because it used to contain some > useless scripts (custom hacky scripts for deb / rpm / targz packaging) > and a jar file (which is not acceptable in Java packaging). The > ds-version merely delete those files. You can do this if it's convenient, but you don't need to -- it's only non-DFSG-free files that have to be filtered out. You can just not install the .jar, which might be easier than making a +ds tarball everytime upstream makes a new release. Also, you could consider using .xz compression for the orig tarball to save space on the Debian mirror network. You can set that in gbp.conf if you're using gbp to generate tarballs. On Thu, Aug 11, 2016 at 12:58:00PM +0800, Boyuan Yang wrote: > > Is the GitHub repo that this package is based on a fork of Nevernote? I > > think you should change the Homepage: field to point at the GitHub > > repo. Or are they controlled by the same person? > > They are controlled by the same person and actually they are the *same > project*. Actually the author is still using nevernote page on > Sourceforge to distribute pre-built nixnote2 packages. I filed https://github.com/baumgarr/nixnote2/issues/198 > > Your version number indicates that you are packaging a beta release. > > Generally, only full upstream releases are uploaded to Debian > > unstable, rather than testing releases/release candidates. Is there > > some good reason for using this version? > > Upstream is keeping "beta" string in version for several years and > there is no sign that he/she will make a "non-beta" release in near > future. However the function of nixnote2 is complete and everything > works well now. Personally I think it is suitable for the release. Okay. > > The description of the "exclude opencv linking" doesn't explain why > > opencv support is disabled "for now". Please explain. > > In upstream trunk the opencv-related functions are disabled and > removed. The developer intends to make it into a plugin, so I disabled > related builds. What's more, I noticed that Debian is preparing > opencv2-3 transition, so my personal preference is to pack the > opencv-related plugin after the transition is completed. The opencv patch has now disappeared. Was that deliberate? > > Vcs-* should point at your packaging repository, not the upstream > > git repository. > > Yes. I am pointing to my packaging repository. Sorry! > > You're installing README.md but this file contains no useful > > information. The README.txt file looks more useful. Does that get > > installed to the help/ dir? I couldn't tell without building the > > package, sorry! > > I did not install README.txt, since this file mainly describes the situation > of source (not the binary). Should I install it anyway? I was thinking that the index of other documentation might be useful -- it explains the purpose of theme.ini. shortcut_howto.txt etc. colors.txt is an example file so it should go into /usr/share/doc/nixnote2/examples. There are some problems with your copyright file: - You're using an outdated format, and the URI in Format-Specification: doesn't work. Please check policy for the current format. - You need a "Files: *" paragraph, and "icons/*" doesn't need to be a separate paragraph. - You should add yourself to the copyright for debian/*. - There is a syntax error too :) In the GPL-2+ paragraph. - Looks like the manpage is copyright Vincent Cheng. Docs go in /usr/share/doc/nixnote2 not /usr/share/nixnote2 -- you're installing several to the wrong place, but some to the right place. The comments in your d/rules file are great. Have you filed an upstream bug about the broken `make install`? You could provide them with your d/install file to help. -- Sean Whitton
signature.asc
Description: PGP signature
