Source: slack
Version: 0.15.2-8
Severity: important
User: [email protected]
Usertags: perl-cwd-inc-removal
Tags: patch

This package FTBFS when '.' is removed from @INC, as seen at [1].
This change is being made for security reasons; for more background,
see #588017 and [2]. Please see the attached patch which fixes this
by explicitly re-adding '.' to @INC where needed in test scripts.

This bug will become RC when the perl package change removing '.' from
@INC by default is uploaded to unstable, expected in a week or two.

By the way, when preparing this patch I found that the git repository
at git://anonscm.debian.org/collab-maint/polymake.git was behind the
Debian archive.

Thanks,
Dominic.

[1] 
<http://perl.debian.net/rebuild-logs/experimental/slack_0.15.2-8/slack_0.15.2-8_amd64-2016-08-16T19%3A05%3A45Z.build>
[2] <https://lists.debian.org/debian-release/2016/07/msg00456.html>
diff -urN slack-0.15.2.orig/test/01_module.t slack-0.15.2/test/01_module.t
--- slack-0.15.2.orig/test/01_module.t	2008-04-21 02:06:10.000000000 +0100
+++ slack-0.15.2/test/01_module.t	2016-08-26 11:17:14.629445024 +0100
@@ -5,7 +5,7 @@
 
 BEGIN {
     chdir 'test' if -d 'test';
-    unshift @INC, '../src';
+    unshift @INC, '../src', '.';
     use_ok("Slack");
 }
 
diff -urN slack-0.15.2.orig/test/02_getroles.t slack-0.15.2/test/02_getroles.t
--- slack-0.15.2.orig/test/02_getroles.t	2008-04-21 02:06:10.000000000 +0100
+++ slack-0.15.2/test/02_getroles.t	2016-08-26 11:17:22.709336964 +0100
@@ -1,5 +1,7 @@
 #!/usr/bin/perl -w
 
+BEGIN { unshift @INC, '.' }
+
 use strict;
 use Test::More tests => 6;
 use test_util;
diff -urN slack-0.15.2.orig/test/03_sync.t slack-0.15.2/test/03_sync.t
--- slack-0.15.2.orig/test/03_sync.t	2008-04-21 02:06:10.000000000 +0100
+++ slack-0.15.2/test/03_sync.t	2016-08-26 11:17:30.901227349 +0100
@@ -1,5 +1,7 @@
 #!/usr/bin/perl -w
 
+BEGIN { unshift @INC, '.' }
+
 use strict;
 use warnings FATAL => qw(all);
 use Test::More;
diff -urN slack-0.15.2.orig/test/04_stage.t slack-0.15.2/test/04_stage.t
--- slack-0.15.2.orig/test/04_stage.t	2008-04-21 02:06:11.000000000 +0100
+++ slack-0.15.2/test/04_stage.t	2016-08-26 11:17:34.629177462 +0100
@@ -1,5 +1,7 @@
 #!/usr/bin/perl -w
 
+BEGIN { unshift @INC, '.' }
+
 use strict;
 use warnings FATAL => qw(all);
 use Test::More tests => 15;
diff -urN slack-0.15.2.orig/test/05_runscript.t slack-0.15.2/test/05_runscript.t
--- slack-0.15.2.orig/test/05_runscript.t	2008-04-21 02:06:10.000000000 +0100
+++ slack-0.15.2/test/05_runscript.t	2016-08-26 11:17:37.877134008 +0100
@@ -1,5 +1,7 @@
 #!/usr/bin/perl -w
 
+BEGIN { unshift @INC, '.' }
+
 use strict;
 use Test::More tests => 18;
 use test_util;
diff -urN slack-0.15.2.orig/test/06_installfiles.t slack-0.15.2/test/06_installfiles.t
--- slack-0.15.2.orig/test/06_installfiles.t	2008-04-21 02:06:10.000000000 +0100
+++ slack-0.15.2/test/06_installfiles.t	2016-08-26 11:17:41.093091097 +0100
@@ -1,5 +1,7 @@
 #!/usr/bin/perl -w
 
+BEGIN { unshift @INC, '.' }
+
 use strict;
 use warnings FATAL => qw(all);
 use Test::More tests => 13;
diff -urN slack-0.15.2.orig/test/07_frontend.t slack-0.15.2/test/07_frontend.t
--- slack-0.15.2.orig/test/07_frontend.t	2008-04-21 02:06:11.000000000 +0100
+++ slack-0.15.2/test/07_frontend.t	2016-08-26 11:17:44.581044326 +0100
@@ -1,5 +1,7 @@
 #!/usr/bin/perl -w
 
+BEGIN { unshift @INC, '.' }
+
 use strict;
 use warnings FATAL => qw(all);
 use Test::More tests => 13;
diff -urN slack-0.15.2.orig/test/08_diff.t slack-0.15.2/test/08_diff.t
--- slack-0.15.2.orig/test/08_diff.t	2008-04-21 02:06:10.000000000 +0100
+++ slack-0.15.2/test/08_diff.t	2016-08-26 11:17:48.100997199 +0100
@@ -1,5 +1,7 @@
 #!/usr/bin/perl -w
 
+BEGIN { unshift @INC, '.' }
+
 use strict;
 use POSIX qw(strftime);
 #use Test::More qw(no_plan); # tests => 12;
diff -urN slack-0.15.2.orig/test/gen_config_file slack-0.15.2/test/gen_config_file
--- slack-0.15.2.orig/test/gen_config_file	2008-04-21 02:06:11.000000000 +0100
+++ slack-0.15.2/test/gen_config_file	2016-08-26 11:17:55.812894220 +0100
@@ -1,5 +1,7 @@
 #!/usr/bin/perl -w
 
+BEGIN { unshift @INC, '.' }
+
 use test_util qw(gen_config_file);
 
 die unless $#ARGV==1;

Reply via email to