Hello Gianfranco: On 31/08/16 08:48, Gianfranco Costamagna wrote: > Hi Jose, are you aware of your RC bugs? >
I was aware of my RC bugs, yes, and I was working on fixing them. > in case, please say something about the ongoing work on git, because there is > no gain in having somebody else prepare an NMU > without acking/nacking changes or thanking him. > I did not look into my bugmail during these last days, sorry about that. Thanks for taking time to work on debugging and fixing the packages. For the next time, please feel free to use the package git so we could add another layer to avoid work duplication. > also, the xml patch looks almost the same as the upstream cherry-pick, and > the link patch looks mostly the same as my patch. > > https://github.com/dartsim/dart/commit/2841967fc6628c9aea58c93227b28abdf5dfbcc2.patch > > Can you please consider setting the correct authorship and forward patches > upstream? > Sorry for not checking upstream code this time. I have the impression that you think that I deliberately miss/remove the credit from patches, that is not the case Gianfranco. I have no reason to do this which goes against what rules open source. I wrote my patches (both were trivial) without using upstream changes or notice the existence of your patch. > (I don't care about authorship, but cherry-picking from upstream, changing it is considered bad). Fully agree here, I will remove my custom patches and use the upstream commit. > I'll assume good faith from your side, and cancel the NMU. > (let me know if you need a sponsor) Thanks for the assumption and the offer, I have rights now to upload changes to kido. -- Jose Luis Rivero <jriv...@osrfoundation.org>
signature.asc
Description: OpenPGP digital signature
