Control: severity -1 serious
Control: tags -1 patch
On Tue, 13 Sep 2016 12:53:27 +0300 Vivia Nikolaidou <n.vi...@gmail.com> wrote:
> Package: vim-youcompleteme
> Version: 0+20160327+git1b76af4-1
> Severity: important
>
> Dear Maintainer,
>
> After yesterday's upgrade, vim-youcompleteme didn't work anymore. It was
> spitting errors into the bottom part of vim complaining about missing python
> modules. I manually apt-get installed python3-future and python3-requests-
> futures and then it worked. Not sure if there are any further modules missing
> that I happened to have installed already.
The problem is that vim 2:7.4.2330-1 switched from using python2 to python3:
[ James McCoy ]
* Switch from Python2 to Python3 language bindings. All packaged
addons which use Python support both 2 & 3. (Closes: #729924)
It appears that this plugin was missing at the time of the check.
The change appears to be fairly simple, as all that is required is to
insert a few '3' here and there. Please find attached a patch
implementing this change.
diff --git a/debian/control b/debian/control
index 1497f51..1a22a14 100644
--- a/debian/control
+++ b/debian/control
@@ -4,13 +4,14 @@ Priority: optional
Maintainer: Onur Aslan <o...@onur.im>
Build-Depends: debhelper (>= 9),
dh-python,
- python,
+ python3,
flake8,
- python-hamcrest,
- python-mock,
- python-nose,
- python-requests,
- python-requests-futures,
+ python3-hamcrest,
+ python3-mock,
+ python3-nose,
+ python3-future,
+ python3-requests,
+ python3-requests-futures,
ycmd (>= 0+20160327+gitc3e6904), ycmd (<< 0+20160327+gitc3e6904.1)
X-Python-Version: >= 2.7
Standards-Version: 3.9.7
@@ -21,10 +22,10 @@ Vcs-Browser: https://anonscm.debian.org/cgit/collab-maint/vim-youcompleteme.git
Package: vim-youcompleteme
Architecture: all
Depends: ${misc:Depends},
- ${python:Depends},
- python-futures,
- python-requests (>= 2.2.1),
- python-requests-futures,
+ ${python3:Depends},
+ python3-futures,
+ python3-requests (>= 2.2.1),
+ python3-requests-futures,
ycmd (>= 0+20160327+gitc3e6904), ycmd (<< 0+20160327+gitc3e6904.1),
vim-nox | vim-python
Recommends: vim-addon-manager
diff --git a/debian/rules b/debian/rules
index da332d3..c2f0aae 100755
--- a/debian/rules
+++ b/debian/rules
@@ -11,7 +11,7 @@ DEB_INSTALL_DIR = $(CURDIR)/debian/$(DEB_SOURCE)
%:
- dh $@ --with python2
+ dh $@ --with python3
override_dh_install:
dh_install
@@ -22,7 +22,7 @@ override_dh_install:
override_dh_auto_test:
ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
flake8 --select=F,C9 --max-complexity=12 python
- PYTHONPATH=/usr/lib/ycmd:$(CURDIR)/third_party/retries nosetests -v --no-byte-compile python
+ PYTHONPATH=/usr/lib/ycmd:$(CURDIR)/third_party/retries nosetests3 -v --no-byte-compile python
endif
get-orig-source:
