Package: spdylay Version: 1.3.2-2 Severity: important Tags: patch Control: block 827061 by -1 Control: user pkg-openssl-devel-requ...@lists.alioth.debian.org Control: usertag -1 openssl-1.1-trans-keypkg Control: usertag -1 openssl-1.1-trans
This package fails currently to compile against openssl 1.1.0 (currently available in experimental). The issues look not openssl specific. The full build of the build failure is available https://breakpoint.cc/openssl-1.1-rebuild-2016-08-26/failed/spdylay_1.3.2-2_amd64-2016-08-26T19%3A47%3A25Z With the patch attached is manages to build. The testsuite fails then :) The SSL error message was obtained via ERR_print_errors_fp(stderr): | ========================================= | spdylay 1.3.2: tests/test-suite.log | ========================================= | | # TOTAL: 3 | # PASS: 2 | # SKIP: 0 | # XFAIL: 0 | # FAIL: 1 | # XPASS: 0 | # ERROR: 0 | | .. contents:: :depth: 2 | | FAIL: end_to_end.py | =================== | | SSL_CTX_use_certificate_file failed. | 140680762493824:error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key too small:ssl/ssl_rsa.c:305: | Could not connect to the host: localhost:9893 | error:1408F10B:SSL routines:ssl3_get_record:wrong version number | Could not connect to the host: localhost:79 | FCould not connect to the host: localhost:2 | .Could not connect to the host: localhost:9893 | Could not connect to the host: localhost:9893 | FCould not connect to the host: localhost:9893 | FCould not connect to the host: localhost:9893 | FSSL_CTX_use_certificate_file failed. | 140100289985408:error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key too small:ssl/ssl_rsa.c:305: | Could not connect to the host: localhost:9893 So it looks like the key in the test is too small. Sebastian
>From 9e74d00a28bf3294722d07a52646a8b1a5740237 Mon Sep 17 00:00:00 2001 From: Sebastian Andrzej Siewior <sebast...@breakpoint.cc> Date: Thu, 15 Sep 2016 20:01:49 +0000 Subject: [PATCH] spdylay: compile against openssl-1.1.0 It fails to compile against openssl 1.1.0 due to things like |shrpx_client_handler.cc:90:30: error: 'strerror' was not declared in this scope |shrpx_listen_handler.cc:112:32: error: 'memset' was not declared in this scope |shrpx_listen_handler.cc:114:43: error: 'memcpy' was not declared in this scope This resolves it. Signed-off-by: Sebastian Andrzej Siewior <sebast...@breakpoint.cc> --- examples/spdycli.c | 1 + src/shrpx.cc | 1 + src/shrpx_client_handler.cc | 1 + src/shrpx_listen_handler.cc | 1 + src/shrpx_ssl.cc | 2 +- 5 files changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/spdycli.c b/examples/spdycli.c index 3874aa4..040ae82 100644 --- a/examples/spdycli.c +++ b/examples/spdycli.c @@ -39,6 +39,7 @@ #include <signal.h> #include <stdio.h> #include <assert.h> +#include <string.h> #include <spdylay/spdylay.h> diff --git a/src/shrpx.cc b/src/shrpx.cc index 65e9afd..f7bd742 100644 --- a/src/shrpx.cc +++ b/src/shrpx.cc @@ -41,6 +41,7 @@ #include <iostream> #include <fstream> #include <vector> +#include <cstring> #include <openssl/ssl.h> #include <openssl/err.h> diff --git a/src/shrpx_client_handler.cc b/src/shrpx_client_handler.cc index df6bb1c..e8db861 100644 --- a/src/shrpx_client_handler.cc +++ b/src/shrpx_client_handler.cc @@ -26,6 +26,7 @@ #include <unistd.h> #include <cerrno> +#include <cstring> #include "shrpx_upstream.h" #include "shrpx_spdy_upstream.h" diff --git a/src/shrpx_listen_handler.cc b/src/shrpx_listen_handler.cc index aabd013..f5b8ac6 100644 --- a/src/shrpx_listen_handler.cc +++ b/src/shrpx_listen_handler.cc @@ -28,6 +28,7 @@ #include <pthread.h> #include <cerrno> +#include <cstring> #include <event2/bufferevent_ssl.h> diff --git a/src/shrpx_ssl.cc b/src/shrpx_ssl.cc index f712816..58753be 100644 --- a/src/shrpx_ssl.cc +++ b/src/shrpx_ssl.cc @@ -30,7 +30,7 @@ #include <pthread.h> #include <vector> -#include <string> +#include <cstring> #include <openssl/crypto.h> #include <openssl/x509.h> -- 2.9.3
