On 2016-09-17 00:57 +0000, Debian Bug Tracking System wrote: OK. The change in nvidia-texture-tools is in fact a valid buffer overflow fix. However it is incomplete and should currently look like the code below:
#if SQUISH_USE_SIMD
Vec4 m_unweighted[17];
Vec4 m_metric;
Vec4 m_metricSqr;
Vec4 m_xxsum;
Vec4 m_xsum;
Vec4 m_besterror;
#else
Vec3 m_unweighted[17];
Vec3 m_metric;
Vec3 m_metricSqr;
Vec3 m_xxsum;
Vec3 m_xsum;
float m_besterror;
#endif
However that only applied in v1.7 which ntt is using, because that
contained an incorrect <=16 test.
In the current 1.13 the <=16 test has been corrected to <16 so the
overflow no longer occurs. This is the correct fix, so this version
should work fine if used by ntt.
Wookey
--
Principal hats: Linaro, Debian, Wookware, ARM
http://wookware.org/
signature.asc
Description: Digital signature
