On 09/18/2016 01:07 PM, John Paul Adrian Glaubitz wrote:
> Sorry guys, was busy this weekend. Will look at it in a few hours :).

There are two issues with the package on mentors that I see:

* It has symbols files for some architectures but not all architectures
  despite the debian/changelog file claiming otherwise.

* The postinst scripts for the -dev and -bin packages call 
  to install symlinks to the documentation folder of the -doc package. However,
  neither the -bin nor the -dev package depend on any way on the -doc
  package. So, in the worst case, the postinst script will fail (I didn't test
  how dpkg-mainscript-helper behaves), the best cases, it creates dangling
  symlinks. Neither is an optimal situation.

The rest of the changes look fine.


 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to