Control: tags -1 + patch
2016-09-17 16:31 GMT+02:00 Raoul Borenius <boren...@dfn.de>:
> Hello Balint,
> On Thu, Sep 15, 2016 at 11:40:57AM +0200, Balint Reczey wrote:
>> I have already asked for many exceptions on d-d:
>> If you agree with the proposed change please add i2util to the list and
>> maybe support the request. It would be nice to see at least one positive
>> answer to call it a discussion. :-)
> I added my package to the list but I did not vote for
> your change, sorry. I'm no C developer so I do not think that
> my vote would be backed by the needed technical know how ;-)
> Your proposal sounds valid to me though, crossing my fingers that
> the developers will agree to it.
OK, thank you.
> I created a new package for i2util:
> I included
> export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow
> DPKG_EXPORT_BUILDFLAGS = 1
> include /usr/share/dpkg/buildflags.mk
> at the top of the rules file. Is that suffient in our case or do
> I need to add
> export DEB_BUILD_MAINT_OPTIONS = hardening=+all
> My understanding is that the latter is not needed with the newest
> build environment.
I suggest using the following patch which is simpler and adds -fPIC:
@@ -1,10 +1,10 @@
-#export DEB_BUILD_MAINT_OPTIONS = hardening=+all
-export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow
-DPKG_EXPORT_BUILDFLAGS = 1
+export DEB_CFLAGS_MAINT_APPEND = -fPIC
+export DEB_LDFLAGS_MAINT_APPEND = -fPIC
[ ! -f Makefile ] || $(MAKE) distclean
I think you can also use the default dh_auto_configure, but I have not
> If the package is ok as it is, would you mind uploading it to
> the archive? Im no DD so I do not have upload rights.
It is recommended to work with the same sponsors and as I see
Martin kindly sponsored your last (iperf3) uploads. If Martin can't
sponsor this upload I would happily do it but I need some more
time to review the package.