Thanks for the patch. Please note that we're in the process of removing Heimdal from testing, and possibly unstable; see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837728
Jelmer On Wed, Sep 28, 2016 at 03:36:31PM +0200, Sergio Gelato wrote: > tag 822749 +patch > thanks > > The attached patch (against the current tip of the Heimdal master branch) > fixes the problem for me. > From 9772490720b7007b4d50fb062fb0d3e776ddb907 Mon Sep 17 00:00:00 2001 > From: Sergio Gelato <[email protected]> > Date: Wed, 28 Sep 2016 15:15:12 +0200 > Subject: [PATCH] Add missing type cast in lib/kadm5/log.c > > On 32-bit architectures with _FILE_OFFSET_BITS=64, > sizeof(off_t) > sizeof(size_t) . > > LOG_HEADER_SZ is #define'd as an expression of type size_t, so in order > to get the sign extension right we need -(off_t)LOG_HEADER_SZ instead of > (off_t)(-LOG_HEADER_SZ). > > Fixes Debian bug #822749, PR 175. > --- > lib/kadm5/log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/kadm5/log.c b/lib/kadm5/log.c > index efe1f78..1f1fcc3 100644 > --- a/lib/kadm5/log.c > +++ b/lib/kadm5/log.c > @@ -2337,7 +2337,7 @@ load_entries_cb(kadm5_server_context *server_context, > * Seek back to the start of the record poayload so we can read the > * whole record. > */ > - if (krb5_storage_seek(sp, -LOG_HEADER_SZ, SEEK_CUR) == -1) > + if (krb5_storage_seek(sp, -(off_t)LOG_HEADER_SZ, SEEK_CUR) == -1) > return errno; > > /* > -- > 2.1.4 >
