I think I did fix this before....

http://launchpadlibrarian.net/251885735/zipl-installer_0.0.33ubuntu1_0.0.33ubuntu2.diff.gz

I guess it did not make over to debian. Will fix soon.

Regards,

Dimitri.


On 9 October 2016 at 19:34, Philipp Kern <pk...@debian.org> wrote:

> Package: zipl-installer
> Version: 0.0.33
> Severity: serious
>
> zipl-installer 0.0.33 breaks installation for normal non-btrfs root
> filesystems.
>
>   (initramfs) cat /proc/cmdline
>   root=/dev/mapper/vg-root rootflags=subvol= BOOT_IMAGE=0
>
> The empty subvol= makes mount barf as it's not a valid ext4 flag. The code
> does not seem too healthy to me either:
>
>   if subvol="$(btrfs subvolume show /target 2>/dev/null | sed -n
> '2s/.*:[\t ]*//p')"
>   then
>       info "Root filesystem on btrfs subvolume ${subvol}"
>       PARAMETER="$PARAMETER rootflags=subvol=${subvol}"
>   fi
>
> It'd have been more helpful to take the output and compare it to the empty
> string instead.
>



-- 
Regards,

Dimitri.

Reply via email to