Op 26-10-2016 om 14:17 schreef Christian Ehrhardt:
Package: dovecot
Version: 1:2.2.25-1
Hi,
I was passing and trying to clean up older bugs for Dovecot on Ubuntu.
I came by this one
https://bugs.launchpad.net/ubuntu/+source/dovecot/+bug/1346740
<https://bugs.launchpad.net/ubuntu/+source/dovecot/+bug/1346740>
And while generally correct in the bug description:
"Upstream dovecot has gone from generating the version string from
DOVECOT_VERSION to DOVECOT_ABI_VERSION. However this hasn't been
updated in dovecot-drac.patch"
I think the action should be another one, and that is to drop the drac
support.
Usually when such things are renamed the old define should be gone,
build would fail and things would be spotted.
Actually, it is not so much a rename. It is an additional define that is
used to distinguish the ABI version from the release version in
DOVECOT_VERSION. The plugin_version symbol is looked up during plugin
load and that fails when the ABI version does not match with what the
installed Dovecot provides. Several sub-minor releases can have the same
ABI version (at least that is the idea).
As it is now, I would expect the Drac plugin to fail at load.
I took the build of the plugin and modified it to stop after preprocessor:
cc -Wall -W -shared -fPIC -DHAVE_CONFIG_H -I../../..
-I../../../src/lib -I../../../src/lib-index -I../../../src/lib-mail
-I../../../src/lib-storage -I../../../src/lib-storage/index
-I../../../src/lib-storage/index/maildir -I../../lib drac-plugin.c -E
-o drac_plugin.E -ldrac
In the result I see it resolving to a value of "2.2.25"
If DOVECOT_ABI_VERSION would be used it would be "2.2.ABIv25(2.2.25)"
Unfortunately I have no drac setup nor have a good idea what it is in
detail.
It is a plugin to implement some sort of Pop-before-SMTP. With the
advent of SMTP AUTH, that should never be used anymore.
I looked into the matter 5 minutes more and I think this is just
outdated, unsupported and should be dropped.
I agree.
http://dovecot.org/pipermail/dovecot/2016-September/105514.html
The currently packaged version matches latest version from
https://osdn.net/projects/dovecot2-drac/
<https://osdn.net/projects/dovecot2-drac/>
No update since 2011 there.
Quoting http://wiki2.dovecot.org/HowTo/PopBSMTPAndDovecot#DRAC
<http://wiki2.dovecot.org/HowTo/PopBSMTPAndDovecot#DRAC> the phrases
"historical" and "no more work" together with being out of tree are
not convincing at all and make me even more suggest dropping it.
Sure we could also just make the minor change to DOVECOT_ABI_VERSION,
but as outlined above I'm not convinced.
Just wanted to hear what your opinion on this is?
I say: drop it. If people really want to use it still, they should
compile it themselves.
Regards,
--
Stephan Bosch
Senior Developer
Phone: +49 2761 75252 00 Fax: +49 2761 75252 30
Email: [email protected]
-------------------------------------------------------------------------------------
Open-Xchange AG, Rollnerstr. 14, 90408 Nuremberg, District Court Nuremberg HRB
24738
Managing Board: Rafael Laguna de la Vera, Carsten Dirks, Uwe Reumuth
Chairman of the Board: Richard Seibt
Dovecot Oy, Lars Sonckin Kaari 10, 02600 Espoo, Finland
Managing Director: Markku Kenttä
Chairman of the Board: Timo Sirainen
Board Member: Carsten Dirks
-------------------------------------------------------------------------------------
