Source: util-linux
Version: 2.28.2-1
Severity: normal
Tags: upstream
Dear Maintainer,
* What led up to the situation?
A bug in the output of "wall" as the letter "ΓΏ" was output as '\377'.
* What exactly did you do (or not do) that was effective (or
ineffective)?
Compiled the source from "testing" with
CC='/usr/bin/gcc'
CFLAGS='-Wall -Wextra -Wformat=2 -Wmissing-prototypes -Wmissing-declarations'
CFLAGS="$CFLAGS "'-Wold-style-definition -Wstrict-prototypes'
CFLAGS="$CFLAGS "'-fstack-protector-strong -O2 -fno-common -funsigned-char'
CXXFLAGS="$CFLAGS "'-Wold-style-cast'
LDFLAGS="-Xlinker --print-map -Xlinker --cref -Xlinker\
--warn-common -Xlinker -Map -Xlinker linker.map"
* What was the outcome of this action?
Too many warnings
* What outcome did you expect instead?
Fewer warnings
###
lib/idcache.c: In function 'new_idcache':
lib/idcache.c:29:17: warning: old-style function definition
[-Wold-style-definition]
struct idcache *new_idcache()
^~~~~~~~~~~
libblkid/src/probe.c:292:5: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr || list_empty(&pr->values))
^
libblkid/src/probe.c: In function 'blkid_probe_get_binary_data':
libblkid/src/probe.c:403:6: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr || !chn)
^~~
libblkid/src/probe.c:403:13: warning: nonnull argument 'chn' compared to NULL
[-Wnonnull-compare]
if (!pr || !chn)
^~~~
libblkid/src/probe.c: In function 'blkid_probe_get_filter':
libblkid/src/probe.c:493:6: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr || chain < 0 || chain >= BLKID_NCHAINS)
^~~
libblkid/src/probe.c: In function '__blkid_probe_invert_filter':
libblkid/src/probe.c:524:5: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr)
^
libblkid/src/probe.c: In function 'blkid_probe_is_tiny':
libblkid/src/probe.c:747:12: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
return pr && (pr->flags & BLKID_FL_TINY_DEV);
~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libblkid/src/probe.c: In function 'blkid_probe_is_cdrom':
libblkid/src/probe.c:755:12: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
return pr && (pr->flags & BLKID_FL_CDROM_DEV);
~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libblkid/src/probe.c: In function 'blkid_probe_get_dimension':
libblkid/src/probe.c:869:5: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr)
^
libblkid/src/probe.c: In function 'blkid_probe_set_dimension':
libblkid/src/probe.c:879:5: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr)
^
libblkid/src/probe.c: In function 'blkid_probe_get_sector':
libblkid/src/probe.c:1364:37: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
((uint64_t) sector) << 9, 0x200) : NULL;
^
libblkid/src/probe.c: In function 'blkid_probe_assign_value':
libblkid/src/probe.c:1371:5: warning: nonnull argument 'name' compared to NULL
[-Wnonnull-compare]
if (!name)
^
libblkid/src/probe.c: In function 'blkid_probe_set_magic':
libblkid/src/probe.c:1465:14: warning: nonnull argument 'magic' compared to
NULL [-Wnonnull-compare]
if (!chn || !magic || !len || chn->binary)
^~~~~~
libblkid/src/probe.c: In function '__blkid_probe_get_value':
libblkid/src/probe.c:1784:6: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr || num < 0)
^~~
libblkid/src/probe.c: In function '__blkid_probe_lookup_value':
libblkid/src/probe.c:1799:5: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr || list_empty(&pr->values) || !name)
^
libblkid/src/probe.c:1799:37: warning: nonnull argument 'name' compared to NULL
[-Wnonnull-compare]
if (!pr || list_empty(&pr->values) || !name)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
libblkid/src/probe.c: In function 'blkid_probe_set_wiper':
libblkid/src/probe.c:1897:5: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr)
^
libblkid/src/probe.c: In function 'blkid_probe_is_wiped':
libblkid/src/probe.c:1930:6: warning: nonnull argument 'pr' compared to NULL
[-Wnonnull-compare]
if (!pr || !size)
^~~
libblkid/src/probe.c:1934:6: warning: nonnull argument 'chn' compared to NULL
[-Wnonnull-compare]
if (chn)
^
libblkid/src/read.c: In function 'blkid_read_cache':
libblkid/src/read.c:398:5: warning: nonnull argument 'cache' compared to NULL
[-Wnonnull-compare]
if (!cache)
^
libblkid/src/save.c: In function 'blkid_flush_cache':
libblkid/src/save.c:89:5: warning: nonnull argument 'cache' compared to NULL
[-Wnonnull-compare]
if (!cache)
^
libblkid/src/tag.c: In function 'blkid_find_tag_dev':
libblkid/src/tag.c:69:6: warning: nonnull argument 'dev' compared to NULL
[-Wnonnull-compare]
if (!dev || !type)
^~~~
libblkid/src/tag.c:69:14: warning: nonnull argument 'type' compared to NULL
[-Wnonnull-compare]
if (!dev || !type)
^~~~~
libblkid/src/tag.c: In function 'blkid_set_tag':
libblkid/src/tag.c:130:6: warning: nonnull argument 'dev' compared to NULL
[-Wnonnull-compare]
if (!dev || !name)
^~~~
libblkid/src/tag.c:130:14: warning: nonnull argument 'name' compared to NULL
[-Wnonnull-compare]
if (!dev || !name)
^~~~~
libmount/src/context.c:371:57: warning: nonnull argument 'cxt' compared to NULL
[-Wnonnull-compare]
return cxt && (cxt->flags & MNT_FL_NOCANONICALIZE) ? 1 : 0;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
libmount/src/context_loopdev.c: In function 'is_mounted_same_loopfile':
libmount/src/context_loopdev.c:96:6: warning: nonnull argument 'target'
compared to NULL [-Wnonnull-compare]
if (!target || !backing_file || mnt_context_get_mtab(cxt, &tb))
^~~~~~~
libmount/src/context_loopdev.c:96:17: warning: nonnull argument 'backing_file'
compared to NULL [-Wnonnull-compare]
if (!target || !backing_file || mnt_context_get_mtab(cxt, &tb))
^~~~~~~~~~~~~
login-utils/sulogin-consoles.c: In function 'append_console':
./include/list.h:178:77: warning: nonnull argument 'consoles' compared to NULL
[-Wnonnull-compare]
((head) && (head)->prev != (head) ? list_entry((head)->prev, type, member) :
NULL)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
login-utils/sulogin-consoles.c:324:10: note: in expansion of macro
'list_last_entry'
last = list_last_entry(consoles, struct console, entry);
^~~~~~~~~~~~~~~
disk-utils/cfdisk.c:118:18: warning: 'color_pairs' defined but not used
[-Wunused-const-variable=]
static const int color_pairs[][2] = {
^~~~~~~~~~~
lib/idcache.c: In function 'new_idcache':
lib/idcache.c:29:17: warning: old-style function definition
[-Wold-style-definition]
struct idcache *new_idcache()
^~~~~~~~~~~
####
Also warnings of the type:
warning: format not a string literal, argument types not checked
[-Wformat-nonliteral]
-- System Information:
Debian Release: stretch/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 3.16.36-1 (SMP w/2 CPU cores)
Locale: LANG=is_IS.iso88591, LC_CTYPE=is_IS.iso88591 (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
-- no debconf information
--
Bjarni I. Gislason
