On Sat, Dec 03, 2016 at 10:19:55AM +0100, Adam Borowski wrote:
> On Fri, Dec 02, 2016 at 02:33:43PM +0100, Bill Allombert wrote:
> > On the other hand, if you write a patch so that consolation does the
> > same as gpm, I would be happy to apply it.
>
> Here you go; the first commit talks to the kernel, using current gpm
> defaults. The second commit allows configuring this by the user, defaulting
> to xfce4-terminal's setting. It is debatable which one is "right" -- turns
> out every GUI terminal I looked at uses a different set.
>
> Even those who do allow configuring the set, though, don't allow altering
> non-ASCII, and I think for a good reason: only a rare user would want to go
> through deciding which of Unicode characters should be included. The kernel
> allows setting only printables between U+00A0..U+00FF anyway.
Thanks a lot!
In tools_usage, could you move --word-chars to 'Other options'
and add some words to explain what is does ?
The manpage looks this way:
--word-chars '-A-Za-z0-9,./?%&#:_=+@~' (ASCII only)
which is not very clear.
In static int goodchar(char x)
maybe it is safer to use unsigned char explicitely:
static int goodchar(unsigned char x)
It might be cleaner to call set_lut() in
tools_device_apply_config() than in event_main().
By the way, do you now what lut stand for ?
Cheers,
--
Bill. <[email protected]>
Imagine a large red swirl here.
