Hi Jonas, On Tue, Dec 06, 2016 at 04:16:12PM +0100, Jonas Meurer wrote: > Hi Guido, > > Am 18.11.2016 um 09:18 schrieb Guido Günther: > > While looking into this in some more details I noticed that we're > > missing the reverse operation. In 'gbp buildpackage' we need to map from > > the Debian version to the upstream tag while in 'gbp dch' we need to > > map from the upstream tag to the debian version. This is not reversible > > since '_' will be mapped back to '~'. Therefore I added a warning to the > > docs. I've also made some simplifications to allow for easier future > > expansion like only allowing for single character replacements for now. > > > > If you have some time it owuld be great if you could have a look > > at these commits: > > > > 0b317eeb649090ab8bdd8507c189477670a91cd1 docs: Use version mangling with > > care > > 7ed5e2b5ffbaf8dec310f98162e653fc95cd45f9 DebianGitRepository: Unmangle > > version > > 25a5d679daf6ca90e03fe3bede787396fc630687 DebianGitRepository: split out > > version mangling > > d360a6d92d744762f9f13555ed03726b6d4ba937 DebianGitRepository: simplify > > version mangling > > I finally found time to look into your updates to version mangling and > everything looks good to me. In fact your implementation is much smarter > than mine was. And thanks for uploading git-buildpackage with enabled > version mangling. > > I'm using it actively with the cryptsetup package already even though I > don't use the unmangling feature as I don't use 'gbp dch'. Migth change > in future :)
Thanks for having a look and reporting back! -- Guido
