Hi Raphaël,

[Raphaël Halimi]
> I didn't know about the isenkram program and I'm pleased to see that
> Debian is at last providing such a tool to help people to get the best
> from their hardware, and I have carefully read your e-mail but still, I
> have some questions that I'd like to ask you.

Of course.

> The first question that comes to my mind is about the way you used
> globbing in this modalias line. What exactly does a "*" globs ?

Think of it case statement in a shell script.

Ie similar to this:

case "$modline" in
     dmi:*:pn*:pvrThinkPad*:rvn*)
        match
        ;;
esac

The * match any number of characters in the string.

> Would this line:
>
> <modalias>dmi:*:pvrThinkPad*:*</modalias>
>
> work as expected, and if not, why ?

I expect it will work.  I expect 'dmi:*:pvrThinkPad*' to work too.

> Secondly, unlike what your snippet suggests, tlp is not only for
> ThinkPads, but works on all brands of laptops, so I'm trying to come up
> with a modalias encompassing all laptops.

Oh, hard. :)

> With information I found on your blog about chassis type, I think that a
> list of suitable modalias lines would be:
>
> <modalias>dmi:*:ct8:*</modalias> ("Portable")
> <modalias>dmi:*:ct9:*</modalias> ("Laptop")
> <modalias>dmi:*:ct10:*</modalias> ("Notebook")
>
> What do you think ?

It might make sense, but I do not know what other modalias values might
make sense.  Perhaps something besides dmi info can be used to match
relevant hardware?

> Also, what about "Hand Held" chassis type ? Is it for phones/tablets ?
> If so, should it be included too ?

Not sure. :)

A goal is to only match relevant hardware, so try to keep matches as
specific as possible.

-- 
Happy hacking
Petter Reinholdtsen

Reply via email to