On 14/12/2016 10:53, Pirate Praveen wrote: > > > On 2016, ഡിസംബർ 14 2:16:46 PM IST, Paolo Greppi <paolo.gre...@libpf.com> > wrote: >> >> Assuming we want to keep node-xtend and node-extend separate, I have >> prepared the update for this one in the alioth repo. >> >> That's because also node-liftoff (which is my ITP pipeline after >> node-fixed) depends on node-extend >= 3.0.0 >> >> I also activated tests and tested reverse dependencies (only >> node-superagent) with pkg-ruby-extras/build. RFS ! > > I think node-superagent only has require tests. We may need to enable tests > or run those tests manually after updating package.json and using npm. >
Not easy. Testing current node-superagent 0.20.0 requires patching the tests like this: --- a/test/node/agency.js +++ b/test/node/agency.js @@ -4,8 +4,10 @@ var express = require('express') , assert = require('assert') , should = require('should'); -app.use(express.cookieParser()); -app.use(express.session({ secret: 'secret' })); +var cookieParser = require('cookie-parser') +var session = require('express-session') +app.use(cookieParser()); +app.use(session({ secret: 'secret' })); app.post('/signin', function(req, res) { but while we have node-cookie-session, express-session is missing. I tried updating node-superagent to current 3.3.0 but to run the tests there we would require should-http ... How would I test with express-session or should-http from npm ? And BTW should I push the work I have done on node-superagent 3.3.0 ti alioth ? P