Hi Michael,
On Sun, Dec 18, 2016 at 10:30:46PM +0100, Michael Stapelberg wrote:
> Thanks for the review! All done:
Thanks for working on this! We're almost there:
$ nosetests -x
..................................................E
======================================================================
ERROR: Failure: ImportError (cannot import name repo_setup)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/nose/loader.py", line 418, in
loadTestsFromName
addr.filename, addr.module)
File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 47, in
importFromPath
return self.importFromDir(dir_path, fqname)
File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 94, in
importFromDir
mod = load_module(part_fqname, fh, filename, desc)
File
"/var/scratch/src/git-buildpackage/git-buildpackage/gbp/scripts/clone.py", line
29, in <module>
from gbp.scripts.common import repo_setup
ImportError: cannot import name repo_setup
It seems the definition of repo_setup itself is missing. Looks good
otherwise.
Cheers,
-- Guido